From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752674AbbICQpP (ORCPT <rfc822;w@1wt.eu>);
	Thu, 3 Sep 2015 12:45:15 -0400
Received: from mga03.intel.com ([134.134.136.65]:43577 "EHLO mga03.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750818AbbICQpN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 3 Sep 2015 12:45:13 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,463,1437462000"; 
   d="scan'208";a="637934492"
Date: Thu, 3 Sep 2015 10:44:53 -0600
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Boaz Harrosh <boaz@plexistor.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
        Christoph Hellwig <hch@lst.de>, Dave Chinner <david@fromorbit.com>,
        Andrew Morton <akpm@osdl.org>,
        Dave Hansen <dave.hansen@linux.intel.com>, linux-nvdimm@ml01.01.org,
        Peter Zijlstra <peterz@infradead.org>, x86@kernel.org,
        Hugh Dickins <hughd@google.com>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, Ingo Molnar <mingo@redhat.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        "H. Peter Anvin" <hpa@zytor.com>, linux-fsdevel@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCH] dax, pmem: add support for msync
Message-ID: <20150903164453.GA10341@linux.intel.com>
Mail-Followup-To: Ross Zwisler <ross.zwisler@linux.intel.com>,
	Boaz Harrosh <boaz@plexistor.com>, Christoph Hellwig <hch@lst.de>,
	Dave Chinner <david@fromorbit.com>, Andrew Morton <akpm@osdl.org>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	linux-nvdimm@lists.01.org, Peter Zijlstra <peterz@infradead.org>,
	x86@kernel.org, Hugh Dickins <hughd@google.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Ingo Molnar <mingo@redhat.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	"H. Peter Anvin" <hpa@zytor.com>, linux-fsdevel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
References: <1441047584-14664-1-git-send-email-ross.zwisler@linux.intel.com>
 <20150831233803.GO3902@dastard>
 <20150901070608.GA5482@lst.de>
 <55E597A1.9090205@plexistor.com>
 <20150902190401.GC32255@linux.intel.com>
 <55E7E962.2000607@plexistor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55E7E962.2000607@plexistor.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 03, 2015 at 09:32:02AM +0300, Boaz Harrosh wrote:
> On 09/02/2015 10:04 PM, Ross Zwisler wrote:
> > On Tue, Sep 01, 2015 at 03:18:41PM +0300, Boaz Harrosh wrote:
> <>
> >> Apps expect all these to work:
> >> 1. open mmap m-write msync ... close
> >> 2. open mmap m-write fsync ... close
> >> 3. open mmap m-write unmap ... fsync close
> >>
> >> 4. open mmap m-write sync ...
> > 
> > So basically you made close have an implicit fsync?  What about the flow that
> > looks like this:
> > 
> > 5. open mmap close m-write
> > 
> 
> What? no, close means ummap because you need a file* attached to your vma
> 
> And you miss-understood me, the vm_opts->close is the *unmap* operation not
> the file::close() operation.
> 
> I meant memory-cl_flush on unmap before the vma goes away.

Ah, got it, thanks for the clarification.