From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756771AbbICQsG (ORCPT ); Thu, 3 Sep 2015 12:48:06 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40634 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751823AbbICQsE (ORCPT ); Thu, 3 Sep 2015 12:48:04 -0400 Date: Thu, 3 Sep 2015 09:48:03 -0700 From: Greg KH To: "J. German Rivera" Cc: arnd@arndb.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, stuart.yoder@freescale.com, bhupesh.sharma@freescale.com, agraf@suse.de, bhamciu1@freescale.com, nir.erez@freescale.com, itai.katz@freescale.com, scottwood@freescale.com, R89243@freescale.com, dan.carpenter@oracle.com, richard.schmitt@freescale.com Subject: Re: [PATCH] staging: fsl-mc: Upgraded MC flibs used in MC bus driver Message-ID: <20150903164803.GC31709@kroah.com> References: <1440003160-28717-1-git-send-email-German.Rivera@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440003160-28717-1-git-send-email-German.Rivera@freescale.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 19, 2015 at 11:52:40AM -0500, J. German Rivera wrote: > Since signatures of flib functions have changed, we had to > change all the corresponding calls in the MC bus driver > > Signed-off-by: J. German Rivera > --- > drivers/staging/fsl-mc/bus/dpbp.c | 232 ++++++++------ > drivers/staging/fsl-mc/bus/dpmcp-cmd.h | 81 +---- > drivers/staging/fsl-mc/bus/dpmcp.c | 123 +++++--- > drivers/staging/fsl-mc/bus/dpmcp.h | 123 +++++--- > drivers/staging/fsl-mc/bus/dpmng.c | 14 +- > drivers/staging/fsl-mc/bus/dprc-cmd.h | 7 +- > drivers/staging/fsl-mc/bus/dprc-driver.c | 61 +++- > drivers/staging/fsl-mc/bus/dprc.c | 464 +++++++++++++++++++++++----- > drivers/staging/fsl-mc/bus/mc-allocator.c | 122 ++++---- > drivers/staging/fsl-mc/bus/mc-bus.c | 72 +++-- > drivers/staging/fsl-mc/bus/mc-sys.c | 188 +++++++++-- > drivers/staging/fsl-mc/include/dpbp-cmd.h | 147 +++++++-- > drivers/staging/fsl-mc/include/dpbp.h | 91 ++++-- > drivers/staging/fsl-mc/include/dpcon-cmd.h | 159 ++++++++-- > drivers/staging/fsl-mc/include/dpmng.h | 14 +- > drivers/staging/fsl-mc/include/dprc.h | 313 +++++++++++++++---- > drivers/staging/fsl-mc/include/mc-cmd.h | 28 +- > drivers/staging/fsl-mc/include/mc-private.h | 17 +- > drivers/staging/fsl-mc/include/mc-sys.h | 51 ++- > 19 files changed, 1661 insertions(+), 646 deletions(-) > > diff --git a/drivers/staging/fsl-mc/bus/dpbp.c b/drivers/staging/fsl-mc/bus/dpbp.c > index d99ab6d..6857a67 100644 > --- a/drivers/staging/fsl-mc/bus/dpbp.c > +++ b/drivers/staging/fsl-mc/bus/dpbp.c > @@ -1,48 +1,52 @@ > -/* Copyright 2013-2014 Freescale Semiconductor Inc. > -* > -* Redistribution and use in source and binary forms, with or without > -* modification, are permitted provided that the following conditions are met: > -* * Redistributions of source code must retain the above copyright > -* notice, this list of conditions and the following disclaimer. > -* * Redistributions in binary form must reproduce the above copyright > -* notice, this list of conditions and the following disclaimer in the > -* documentation and/or other materials provided with the distribution. > -* * Neither the name of the above-listed copyright holders nor the > -* names of any contributors may be used to endorse or promote products > -* derived from this software without specific prior written permission. > -* > -* > -* ALTERNATIVELY, this software may be distributed under the terms of the > -* GNU General Public License ("GPL") as published by the Free Software > -* Foundation, either version 2 of that License or (at your option) any > -* later version. > -* > -* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" > -* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE > -* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE > -* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE > -* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR > -* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF > -* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS > -* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN > -* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) > -* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE > -* POSSIBILITY OF SUCH DAMAGE. > -*/ > +/* Copyright 2013-2015 Freescale Semiconductor Inc. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions are met: > + * * Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * * Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in the > + * documentation and/or other materials provided with the distribution. > + * * Neither the name of the above-listed copyright holders nor the > + * names of any contributors may be used to endorse or promote products > + * derived from this software without specific prior written permission. > + * > + * > + * ALTERNATIVELY, this software may be distributed under the terms of the > + * GNU General Public License ("GPL") as published by the Free Software > + * Foundation, either version 2 of that License or (at your option) any > + * later version. > + * > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" > + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE > + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE > + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR > + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF > + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS > + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN > + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) > + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE > + * POSSIBILITY OF SUCH DAMAGE. > + */ Changing the header of a file is not changing an API, please break this up into logical pieces, this can't be taken as-is at all :(