linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dimitri Sivanich <sivanich@sgi.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] drivers/misc/sgi-gru: remove unused variable
Date: Thu, 3 Sep 2015 13:22:13 -0500	[thread overview]
Message-ID: <20150903182213.GB4319@sgi.com> (raw)
In-Reply-To: <1441291851-29411-5-git-send-email-sudipm.mukherjee@gmail.com>

Acked-by: Dimitri Sivanich <sivanich@sgi.com>

On Thu, Sep 03, 2015 at 08:20:51PM +0530, Sudip Mukherjee wrote:
> dw was only assigned some value and was never reused.
> 
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> 
> v2: It was part of first patch in v1. But since one logical change in
> one patch so it had to be removed from first patch and became separate.
> 
>  drivers/misc/sgi-gru/grukservices.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/misc/sgi-gru/grukservices.c b/drivers/misc/sgi-gru/grukservices.c
> index d64f2a0..ba2d2e5 100644
> --- a/drivers/misc/sgi-gru/grukservices.c
> +++ b/drivers/misc/sgi-gru/grukservices.c
> @@ -1004,7 +1004,6 @@ static int quicktest1(unsigned long arg)
>  {
>  	struct gru_message_queue_desc mqd;
>  	void *p, *mq;
> -	unsigned long *dw;
>  	int i, ret = -EIO;
>  	char mes[GRU_CACHE_LINE_BYTES], *m;
>  
> @@ -1014,7 +1013,6 @@ static int quicktest1(unsigned long arg)
>  		return -ENOMEM;
>  	mq = ALIGNUP(p, 1024);
>  	memset(mes, 0xee, sizeof(mes));
> -	dw = mq;
>  
>  	gru_create_message_queue(&mqd, mq, 8 * GRU_CACHE_LINE_BYTES, 0, 0, 0);
>  	for (i = 0; i < 6; i++) {
> -- 
> 1.9.1

  reply	other threads:[~2015-09-03 18:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-03 14:50 [PATCH v2 1/5] drivers/misc/sgi-gru: add return on error Sudip Mukherjee
2015-09-03 14:50 ` [PATCH v2 2/5] drivers/misc/sgi-gru: make functions static Sudip Mukherjee
2015-09-03 14:50 ` [PATCH v2 3/5] drivers/misc/sgi-gru: remove always false condition Sudip Mukherjee
2015-09-03 14:50 ` [PATCH v2 4/5] drivers/misc/sgi-gru: fix dereference of ERR_PTR Sudip Mukherjee
2015-09-03 18:45   ` Dimitri Sivanich
2015-09-04  4:26   ` [PATCH v3] " Sudip Mukherjee
2015-09-04 12:56     ` Dimitri Sivanich
2015-09-03 14:50 ` [PATCH v2 5/5] drivers/misc/sgi-gru: remove unused variable Sudip Mukherjee
2015-09-03 18:22   ` Dimitri Sivanich [this message]
2015-09-03 18:21 ` [PATCH v2 1/5] drivers/misc/sgi-gru: add return on error Dimitri Sivanich
2015-09-15  7:50   ` Sudip Mukherjee
2015-09-21  2:26     ` Greg Kroah-Hartman
2015-09-21  5:34       ` Sudip Mukherjee
2015-09-21  5:36         ` Greg Kroah-Hartman
2015-09-21  6:53           ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150903182213.GB4319@sgi.com \
    --to=sivanich@sgi.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).