From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932657AbbICSWP (ORCPT ); Thu, 3 Sep 2015 14:22:15 -0400 Received: from relay3.sgi.com ([192.48.152.1]:37999 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932473AbbICSWO (ORCPT ); Thu, 3 Sep 2015 14:22:14 -0400 Date: Thu, 3 Sep 2015 13:22:13 -0500 From: Dimitri Sivanich To: Sudip Mukherjee Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/5] drivers/misc/sgi-gru: remove unused variable Message-ID: <20150903182213.GB4319@sgi.com> References: <1441291851-29411-1-git-send-email-sudipm.mukherjee@gmail.com> <1441291851-29411-5-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441291851-29411-5-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-by: Dimitri Sivanich On Thu, Sep 03, 2015 at 08:20:51PM +0530, Sudip Mukherjee wrote: > dw was only assigned some value and was never reused. > > Signed-off-by: Sudip Mukherjee > --- > > v2: It was part of first patch in v1. But since one logical change in > one patch so it had to be removed from first patch and became separate. > > drivers/misc/sgi-gru/grukservices.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/misc/sgi-gru/grukservices.c b/drivers/misc/sgi-gru/grukservices.c > index d64f2a0..ba2d2e5 100644 > --- a/drivers/misc/sgi-gru/grukservices.c > +++ b/drivers/misc/sgi-gru/grukservices.c > @@ -1004,7 +1004,6 @@ static int quicktest1(unsigned long arg) > { > struct gru_message_queue_desc mqd; > void *p, *mq; > - unsigned long *dw; > int i, ret = -EIO; > char mes[GRU_CACHE_LINE_BYTES], *m; > > @@ -1014,7 +1013,6 @@ static int quicktest1(unsigned long arg) > return -ENOMEM; > mq = ALIGNUP(p, 1024); > memset(mes, 0xee, sizeof(mes)); > - dw = mq; > > gru_create_message_queue(&mqd, mq, 8 * GRU_CACHE_LINE_BYTES, 0, 0, 0); > for (i = 0; i < 6; i++) { > -- > 1.9.1