From: Darren Hart <dvhart@infradead.org>
To: Josh Boyer <jwboyer@fedoraproject.org>
Cc: Joe Perches <joe@perches.com>, Chen Yu <yu.c.chen@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg KH <gregkh@linuxfoundation.org>,
mchehab@osg.samsung.com, David Miller <davem@davemloft.net>,
Jiri Slaby <jslaby@suse.com>, Tejun Heo <tj@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Zhang Rui <rui.zhang@intel.com>,
platform-driver-x86@vger.kernel.org,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [v4] surface pro 3: Add support driver for Surface Pro 3 buttons
Date: Thu, 3 Sep 2015 12:19:57 -0700 [thread overview]
Message-ID: <20150903191957.GA55382@vmdeb7> (raw)
In-Reply-To: <CA+5PVA7a6adkEA=MApM5o=ohu47kh_srKQq27O5RoT5TOg8_1Q@mail.gmail.com>
On Tue, Sep 01, 2015 at 01:30:27PM -0400, Josh Boyer wrote:
> On Fri, Aug 28, 2015 at 1:56 PM, Darren Hart <dvhart@infradead.org> wrote:
> > On Wed, Aug 26, 2015 at 05:04:01AM -0700, Joe Perches wrote:
> >> On Wed, 2015-08-26 at 00:22 -0700, Darren Hart wrote:
> >> > On Tue, Aug 18, 2015 at 11:30:25PM +0800, Chen Yu wrote:
> >> > > Since Surface Pro 3 does not follow the specs of "Windows ACPI Design
> >> > > Guide for SoC Platform", code in drivers/input/misc/soc_array.c can
> >> > > not detect these buttons on it. According to bios implementation,
> >> > > Surface Pro 3 encapsulates these buttons in a device named "VGBI",
> >> > > with _HID "MSHW0028". When any of the buttons is pressed, a specify
> >> > > ACPI notification code for this button will be delivered to "VGBI". For
> >> > > example, if power button is pressed down, ACPI notification code of 0xc6
> >> > > will be sent by Notify(VGBI, 0xc6).
> >> []
> >> > Joe, you provided a lot of review, are you happy with this version?
> >>
> >> It looks fine.
> >>
> >> Thanks for picking the other little nits too Darren.
> >
> > This is not queued for next.
>
> Not or now? If not, why not?
Sorry, typo :-)
It is queued for next, you'll find it in my "for-next" branch as well as in
linux-next currently.
--
Darren Hart
Intel Open Source Technology Center
prev parent reply other threads:[~2015-09-03 19:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 15:30 [PATCH] [v4] surface pro 3: Add support driver for Surface Pro 3 buttons Chen Yu
2015-08-26 7:22 ` Darren Hart
2015-08-26 12:04 ` Joe Perches
2015-08-28 17:56 ` Darren Hart
2015-09-01 17:30 ` Josh Boyer
2015-09-03 19:19 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150903191957.GA55382@vmdeb7 \
--to=dvhart@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=jslaby@suse.com \
--cc=jwboyer@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=tj@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).