From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758449AbbIDIZ7 (ORCPT ); Fri, 4 Sep 2015 04:25:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38667 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758395AbbIDIZy (ORCPT ); Fri, 4 Sep 2015 04:25:54 -0400 Date: Fri, 4 Sep 2015 10:25:48 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 1/9] perf, tools, stat: Move sw clock metrics printout to stat-shadow Message-ID: <20150904082548.GA12338@krava.redhat.com> References: <1441236954-24886-1-git-send-email-andi@firstfloor.org> <1441236954-24886-2-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441236954-24886-2-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 02, 2015 at 04:35:46PM -0700, Andi Kleen wrote: > From: Andi Kleen > > The sw clock metrics printing was missed in the earlier move to > stat-shadow of all the other metric printouts. Move it too. > > Signed-off-by: Andi Kleen > --- > tools/perf/builtin-stat.c | 9 --------- > tools/perf/util/stat-shadow.c | 3 +++ > 2 files changed, 3 insertions(+), 9 deletions(-) > > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c > index a96fb5c..77e5781 100644 > --- a/tools/perf/builtin-stat.c > +++ b/tools/perf/builtin-stat.c > @@ -510,15 +510,6 @@ static void nsec_printout(int id, int nr, struct perf_evsel *evsel, double avg) > > if (evsel->cgrp) > fprintf(output, "%s%s", csv_sep, evsel->cgrp->name); > - > - if (csv_output || stat_config.interval) > - return; > - > - if (perf_evsel__match(evsel, SOFTWARE, SW_TASK_CLOCK)) > - fprintf(output, " # %8.3f CPUs utilized ", > - avg / avg_stats(&walltime_nsecs_stats)); > - else > - fprintf(output, " "); > } > > static void abs_printout(int id, int nr, struct perf_evsel *evsel, double avg) > diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c > index 2a5d8d7..625ab3b 100644 > --- a/tools/perf/util/stat-shadow.c > +++ b/tools/perf/util/stat-shadow.c > @@ -413,6 +413,9 @@ void perf_stat__print_shadow_stats(FILE *out, struct perf_evsel *evsel, > ratio = total / avg; > > fprintf(out, " # %8.0f cycles / elision ", ratio); > + } else if (perf_evsel__match(evsel, SOFTWARE, SW_TASK_CLOCK) && > + (ratio = avg_stats(&walltime_nsecs_stats)) != 0) { > + fprintf(out, " # %8.3f CPUs utilized ", avg / ratio); perf_stat__print_shadow_stats is at this point called only from abs_printout, while this is nsec_printout.. but it's all factored later, so I believe this is ok for now Acked-by: Jiri Olsa thanks, jirka