From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758486AbbIDIvX (ORCPT ); Fri, 4 Sep 2015 04:51:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48286 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752906AbbIDIvV (ORCPT ); Fri, 4 Sep 2015 04:51:21 -0400 Date: Fri, 4 Sep 2015 10:51:16 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 8/9] perf, tools, stat: Remove extra unsupported/not counted handling Message-ID: <20150904085116.GD12338@krava.redhat.com> References: <1441236954-24886-1-git-send-email-andi@firstfloor.org> <1441236954-24886-9-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441236954-24886-9-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 02, 2015 at 04:35:53PM -0700, Andi Kleen wrote: > From: Andi Kleen > > printout now handles unsupported/not counted printing, so we can > remove one extra instance in the aggregated printing. > > Signed-off-by: Andi Kleen > --- > tools/perf/builtin-stat.c | 22 ++-------------------- > 1 file changed, 2 insertions(+), 20 deletions(-) > > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c > index f049fa67c..68c16e6 100644 > --- a/tools/perf/builtin-stat.c > +++ b/tools/perf/builtin-stat.c > @@ -841,26 +841,8 @@ static void print_counter_aggr(struct perf_evsel *counter, char *prefix) > if (prefix) > fprintf(output, "%s", prefix); > > - if (scaled == -1 || !counter->supported) { > - fprintf(output, "%*s%s", > - csv_output ? 0 : 18, > - counter->supported ? CNTR_NOT_COUNTED : CNTR_NOT_SUPPORTED, > - csv_sep); > - fprintf(output, "%-*s%s", > - csv_output ? 0 : unit_width, > - counter->unit, csv_sep); > - fprintf(output, "%*s", > - csv_output ? 0 : -25, > - perf_evsel__name(counter)); > - > - if (counter->cgrp) > - fprintf(output, "%s%s", csv_sep, counter->cgrp->name); > - > - print_running(avg_running, avg_enabled); > - fputc('\n', output); > - return; > - } why is this not part of the: perf, tools, stat: Move non counting counter printing to printout jirka