From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758575AbbIDJCB (ORCPT ); Fri, 4 Sep 2015 05:02:01 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:34307 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753176AbbIDJB6 (ORCPT ); Fri, 4 Sep 2015 05:01:58 -0400 Date: Fri, 4 Sep 2015 11:01:54 +0200 From: Ingo Molnar To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Adrian Hunter , David Ahern , Jiri Olsa , Matt Fleming , Namhyung Kim , Peter Zijlstra , Raphael Beamonte , Steven Rostedt , Arnaldo Carvalho de Melo Subject: Re: [GIT PULL 0/2] perf/urgent fixes Message-ID: <20150904090153.GB17456@gmail.com> References: <1441296129-31530-1-git-send-email-acme@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441296129-31530-1-git-send-email-acme@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Arnaldo Carvalho de Melo wrote: > Hi Ingo, > > Please consider pulling, > > - Arnaldo > > The following changes since commit 5b923564ccf43f92969c9e0fd199c8c5db657039: > > Merge tag 'perf-urgent-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2015-09-02 09:22:53 +0200) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo > > for you to fetch changes up to 53ff6bc37be449f546158a39c528d7814dfb15a1: > > perf tools: Fix use of wrong event when processing exit events (2015-09-02 17:46:26 -0300) > > ---------------------------------------------------------------- > perf/urgent fixes: > > - In some cases where perf_event.fork.{pid,tid} should be used we were instead > using perf_event.comm.{pid,tid}, which is not a problem for for the 'pid' > case, that sits in the same place in these union_perf_event members, but > comm.tid sits where fork.ppid is, oops. > > These cases were considered as (potentially) problematic: > > - 'perf script' with !sample_id_all, i.e. only non old kernels without > perf_event_attr.sample_id_all. > > - intel_pt could be affected when decoding without timestamps, as the exit > event is only used to flush out data which anyway gets flushed at the > end of the session. > > - intel_bts also uses the exit event to flush data which would probably not > cause errors as it would get flushed at the end of the session instead. > > Fix it. (Adrian Hunter) > > - Due to relaxing the compiler checks for bison generated files, we missed > updating one parse_events_add_pmu() caller when this function had its > prototype changed, fix it. (Jiri Olsa) > > Signed-off-by: Arnaldo Carvalho de Melo > > ---------------------------------------------------------------- > Adrian Hunter (1): > perf tools: Fix use of wrong event when processing exit events > > Jiri Olsa (1): > perf tools: Fix parse_events_add_pmu caller > > tools/perf/builtin-script.c | 4 ++-- > tools/perf/util/intel-bts.c | 2 +- > tools/perf/util/intel-pt.c | 2 +- > tools/perf/util/parse-events.y | 2 +- > 4 files changed, 5 insertions(+), 5 deletions(-) Pulled, thanks a lot Arnaldo! Ingo