Re: [PATCH 12/15] tools lib api: Add configured support for fs

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Fri, Sep 04, 2015 at 09:08:45AM +0200, Jiri Olsa escreveu:
> On Wed, Sep 02, 2015 at 01:52:28PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Sep 02, 2015 at 11:17:59AM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Wed, Sep 02, 2015 at 03:46:25PM +0200, Jiri Olsa escreveu:
> > > > On Wed, Sep 02, 2015 at 10:39:31AM -0300, Arnaldo Carvalho de Melo wrote:
> > > > > Em Wed, Sep 02, 2015 at 09:56:42AM +0200, Jiri Olsa escreveu:
> > > > > > Adding name__mount (where name is in sysfs,procfs,debugfs,tracefs)
> > > 
> > > The cut'n'paste error I mentioned was in the above line, BTW.
> > > 
> > > > > > interface that returns bool state of the filesystem mount:
> > > > > >   true - mounted, false - not mounted
> > > > > 
> > > > > Well, why not take the opportunity and call it... name__mounted()?
> > > > > "__configured()" is too vague...
> > > > 
> > > > I mirrored the debugfs/tracefs object interface
> > > > we can have another patch changing that
> > > 
> > > Ok, agreed, will leave it as configured() and then we can change it.
> > 
> > What I have is at my tmp.perf/core branch, out for lunch.
> 
> I can see all of it in your's perf/core apart from:
> 
> Applying: tools lib api: Make tracing_path_strerror_open message generic
> Applying: tools lib api: Replace debugfs/tracefs objects interface with fs.c
> Applying: tools lib api: Remove debugfs, tracefs and findfs objects
> Applying: perf tools: Switch to tracing_path interface on appropriate places
> 
> should I repost or do you plan to take it? I didn't get any comments on those

I'll get back to those, its just that the number of patches in my
perf/core branch was getting too high, better flush it a bit, will
continue.

If you can just make sure that a rebase on top of my perf/core goes
well, that helps.

- Arnaldo