Re: [Xen-devel] [PATCH] xen-blkback: free requests on disconnection

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Fri, Sep 04, 2015 at 02:51:10PM +0100, Julien Grall wrote:
> Hi Roger,
> 
> On 04/09/15 11:08, Roger Pau Monne wrote:
> > Request allocation has been moved to connect_ring, which is called every
> > time blkback connects to the frontend (this can happen multiple times during
> > a blkback instance life cycle). On the other hand, request freeing has not
> > been moved, so it's only called when destroying the backend instance. Due to
> > this mismatch, blkback can allocate the request pool multiple times, without
> > freeing it.
> > 
> > In order to fix it, move the freeing of requests to xen_blkif_disconnect to
> > restore the symmetry between request allocation and freeing.
> > 
> > Reported-by: Julien Grall <julien.grall@citrix.com>
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > Cc: Julien Grall <julien.grall@citrix.com>
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> > Cc: David Vrabel <david.vrabel@citrix.com>
> > Cc: xen-devel@lists.xenproject.org
> 
> The patch is fixing my problem when using UEFI in the guest. Thank you!
> 
> Tested-by: Julien Grall <julien.grall@citrix.com>

Testing it now for regressions and should be sending an git pull next week
for it.

Thanks!
> 
> Regards,
> 
> -- 
> Julien Grall
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel