From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933129AbbIDRVb (ORCPT ); Fri, 4 Sep 2015 13:21:31 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:22182 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932892AbbIDRV3 convert rfc822-to-8bit (ORCPT ); Fri, 4 Sep 2015 13:21:29 -0400 Date: Fri, 4 Sep 2015 13:21:22 -0400 From: Konrad Rzeszutek Wilk To: Julien Grall Cc: Roger Pau Monne , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, Boris Ostrovsky , David Vrabel Subject: Re: [Xen-devel] [PATCH] xen-blkback: free requests on disconnection Message-ID: <20150904172122.GB2042@l.oracle.com> References: <1441361287-41234-1-git-send-email-roger.pau@citrix.com> <55E9A1CE.9090905@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <55E9A1CE.9090905@citrix.com> User-Agent: Mutt/1.5.23 (2014-03-12) Content-Transfer-Encoding: 8BIT X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 04, 2015 at 02:51:10PM +0100, Julien Grall wrote: > Hi Roger, > > On 04/09/15 11:08, Roger Pau Monne wrote: > > Request allocation has been moved to connect_ring, which is called every > > time blkback connects to the frontend (this can happen multiple times during > > a blkback instance life cycle). On the other hand, request freeing has not > > been moved, so it's only called when destroying the backend instance. Due to > > this mismatch, blkback can allocate the request pool multiple times, without > > freeing it. > > > > In order to fix it, move the freeing of requests to xen_blkif_disconnect to > > restore the symmetry between request allocation and freeing. > > > > Reported-by: Julien Grall > > Signed-off-by: Roger Pau Monné > > Cc: Julien Grall > > Cc: Konrad Rzeszutek Wilk > > Cc: Boris Ostrovsky > > Cc: David Vrabel > > Cc: xen-devel@lists.xenproject.org > > The patch is fixing my problem when using UEFI in the guest. Thank you! > > Tested-by: Julien Grall Testing it now for regressions and should be sending an git pull next week for it. Thanks! > > Regards, > > -- > Julien Grall > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel