public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Jose Rivera <German.Rivera@freescale.com>
Cc: Nayeemahmed Badebade <itachi.opsrc@gmail.com>,
	Stuart Yoder <stuart.yoder@freescale.com>,
	"agraf@suse.de" <agraf@suse.de>,
	"hgujulan@visteon.com" <hgujulan@visteon.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: fsl-mc/bus: mc-bus.c: Fixed coding style issues
Date: Fri, 4 Sep 2015 11:00:17 -0700	[thread overview]
Message-ID: <20150904180017.GA6649@kroah.com> (raw)
In-Reply-To: <DM2PR0301MB1309B0D0FC9356312A834DE4FE570@DM2PR0301MB1309.namprd03.prod.outlook.com>

On Fri, Sep 04, 2015 at 05:48:55PM +0000, Jose Rivera wrote:
> > -----Original Message-----
> > From: Nayeemahmed Badebade [mailto:itachi.opsrc@gmail.com]
> > Sent: Friday, September 04, 2015 12:01 PM
> > To: gregkh@linuxfoundation.org
> > Cc: Rivera Jose-B46482; Yoder Stuart-B08248; agraf@suse.de;
> > hgujulan@visteon.com; linux-kernel@vger.kernel.org
> > Subject: [PATCH] Staging: fsl-mc/bus: mc-bus.c: Fixed coding style issues
> > 
> > Fixed coding style issues where kernel types u16,u64,u32 should be
> > preferred over uint16_t,uint64_t,uint32_t
> > 
> Nayeemahmed,
> 
> Thanks for your interests in helping us clean up this coding style issue.
> However, doing this for all the files related to the MC bus driver (not just
> for one) is something that I intend to do in a future patch as
> part of the "Cleanup" item of our TODO list.
> Doing this clean up across the board for all files is preferable than 
> doing it just for this file in this patch.

Sorry, but we never postpone a change submitted by someone just because
someone says "sometime in the future we will be making much the same
change".  That's a sure way to kill productivity and stop developers
from helping you out.

If you really wanted to make this type of change, you would have done so
already, so obviously it's not a high priority.  I'll take Nayeemahmed's
patch.

greg k-h

  reply	other threads:[~2015-09-04 18:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-21 17:24 [PATCH] Staging: fsl-mc/bus: mc-bus.c: Fixed coding style issues nayeem
2015-09-03 16:48 ` Greg KH
2015-09-04 17:00   ` Nayeemahmed Badebade
2015-09-04 17:48     ` Jose Rivera
2015-09-04 18:00       ` gregkh [this message]
2015-09-04 18:33         ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150904180017.GA6649@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=German.Rivera@freescale.com \
    --cc=agraf@suse.de \
    --cc=hgujulan@visteon.com \
    --cc=itachi.opsrc@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stuart.yoder@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox