[PATCH] Staging: fsl-mc/bus: mc-bus.c: Fixed coding style issues

[PATCH] Staging: fsl-mc/bus: mc-bus.c: Fixed coding style issues

[nayeem]

Fixed coding style issues where kernel types u16,u64,u32 should
be preferred over uint16_t,uint64_t,uint32_t

Signed-off-by: Nayeemahmed Badebade <itachi.opsrc@gmail.com>
---
 drivers/staging/fsl-mc/bus/mc-bus.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/fsl-mc/bus/mc-bus.c b/drivers/staging/fsl-mc/bus/mc-bus.c
index 766a659..b3a60a0 100644
--- a/drivers/staging/fsl-mc/bus/mc-bus.c
+++ b/drivers/staging/fsl-mc/bus/mc-bus.c
@@ -209,7 +209,7 @@ EXPORT_SYMBOL_GPL(fsl_mc_driver_unregister);
 static int get_dprc_icid(struct fsl_mc_io *mc_io,
 			 int container_id, uint16_t *icid)
 {
-	uint16_t dprc_handle;
+	u16 dprc_handle;
 	struct dprc_attributes attr;
 	int error;
 
@@ -234,7 +234,7 @@ common_cleanup:
 	return error;
 }
 
-static int translate_mc_addr(uint64_t mc_addr, phys_addr_t *phys_addr)
+static int translate_mc_addr(u64 mc_addr, phys_addr_t *phys_addr)
 {
 	int i;
 	struct fsl_mc *mc = dev_get_drvdata(fsl_mc_bus_type.dev_root->parent);
@@ -600,7 +600,7 @@ static int fsl_mc_bus_probe(struct platform_device *pdev)
 	struct fsl_mc_io *mc_io = NULL;
 	int container_id;
 	phys_addr_t mc_portal_phys_addr;
-	uint32_t mc_portal_size;
+	u32 mc_portal_size;
 	struct mc_version mc_version;
 	struct resource res;
 
-- 
1.9.1

Re: [PATCH] Staging: fsl-mc/bus: mc-bus.c: Fixed coding style issues

[Greg KH]

On Fri, Aug 21, 2015 at 10:54:57PM +0530, nayeem wrote:
> Fixed coding style issues where kernel types u16,u64,u32 should
> be preferred over uint16_t,uint64_t,uint32_t
> 
> Signed-off-by: Nayeemahmed Badebade <itachi.opsrc@gmail.com>

This name needs to match your name in the "From:" line of your email.

Please fix up and resend.

thanks,

greg k-h

[PATCH] Staging: fsl-mc/bus: mc-bus.c: Fixed coding style issues

[Nayeemahmed Badebade]

Fixed coding style issues where kernel types u16,u64,u32 should
be preferred over uint16_t,uint64_t,uint32_t

Signed-off-by: Nayeemahmed Badebade <itachi.opsrc@gmail.com>
---
 drivers/staging/fsl-mc/bus/mc-bus.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/fsl-mc/bus/mc-bus.c b/drivers/staging/fsl-mc/bus/mc-bus.c
index 766a659..b3a60a0 100644
--- a/drivers/staging/fsl-mc/bus/mc-bus.c
+++ b/drivers/staging/fsl-mc/bus/mc-bus.c
@@ -209,7 +209,7 @@ EXPORT_SYMBOL_GPL(fsl_mc_driver_unregister);
 static int get_dprc_icid(struct fsl_mc_io *mc_io,
 			 int container_id, uint16_t *icid)
 {
-	uint16_t dprc_handle;
+	u16 dprc_handle;
 	struct dprc_attributes attr;
 	int error;
 
@@ -234,7 +234,7 @@ common_cleanup:
 	return error;
 }
 
-static int translate_mc_addr(uint64_t mc_addr, phys_addr_t *phys_addr)
+static int translate_mc_addr(u64 mc_addr, phys_addr_t *phys_addr)
 {
 	int i;
 	struct fsl_mc *mc = dev_get_drvdata(fsl_mc_bus_type.dev_root->parent);
@@ -600,7 +600,7 @@ static int fsl_mc_bus_probe(struct platform_device *pdev)
 	struct fsl_mc_io *mc_io = NULL;
 	int container_id;
 	phys_addr_t mc_portal_phys_addr;
-	uint32_t mc_portal_size;
+	u32 mc_portal_size;
 	struct mc_version mc_version;
 	struct resource res;
 
-- 
1.9.1

RE: [PATCH] Staging: fsl-mc/bus: mc-bus.c: Fixed coding style issues

[Jose Rivera]

> -----Original Message-----
> From: Nayeemahmed Badebade [mailto:itachi.opsrc@gmail.com]
> Sent: Friday, September 04, 2015 12:01 PM
> To: gregkh@linuxfoundation.org
> Cc: Rivera Jose-B46482; Yoder Stuart-B08248; agraf@suse.de;
> hgujulan@visteon.com; linux-kernel@vger.kernel.org
> Subject: [PATCH] Staging: fsl-mc/bus: mc-bus.c: Fixed coding style issues
> 
> Fixed coding style issues where kernel types u16,u64,u32 should be
> preferred over uint16_t,uint64_t,uint32_t
> 
Nayeemahmed,

Thanks for your interests in helping us clean up this coding style issue.
However, doing this for all the files related to the MC bus driver (not just
for one) is something that I intend to do in a future patch as
part of the "Cleanup" item of our TODO list.
Doing this clean up across the board for all files is preferable than 
doing it just for this file in this patch.
Thanks,

German

> Signed-off-by: Nayeemahmed Badebade <itachi.opsrc@gmail.com>
> ---
>  drivers/staging/fsl-mc/bus/mc-bus.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/fsl-mc/bus/mc-bus.c b/drivers/staging/fsl-
> mc/bus/mc-bus.c
> index 766a659..b3a60a0 100644
> --- a/drivers/staging/fsl-mc/bus/mc-bus.c
> +++ b/drivers/staging/fsl-mc/bus/mc-bus.c
> @@ -209,7 +209,7 @@ EXPORT_SYMBOL_GPL(fsl_mc_driver_unregister);
>  static int get_dprc_icid(struct fsl_mc_io *mc_io,
>  			 int container_id, uint16_t *icid)
>  {
> -	uint16_t dprc_handle;
> +	u16 dprc_handle;
>  	struct dprc_attributes attr;
>  	int error;
> 
> @@ -234,7 +234,7 @@ common_cleanup:
>  	return error;
>  }
> 
> -static int translate_mc_addr(uint64_t mc_addr, phys_addr_t *phys_addr)
> +static int translate_mc_addr(u64 mc_addr, phys_addr_t *phys_addr)
>  {
>  	int i;
>  	struct fsl_mc *mc = dev_get_drvdata(fsl_mc_bus_type.dev_root-
> >parent);
> @@ -600,7 +600,7 @@ static int fsl_mc_bus_probe(struct platform_device
> *pdev)
>  	struct fsl_mc_io *mc_io = NULL;
>  	int container_id;
>  	phys_addr_t mc_portal_phys_addr;
> -	uint32_t mc_portal_size;
> +	u32 mc_portal_size;
>  	struct mc_version mc_version;
>  	struct resource res;
> 
> --
> 1.9.1

Re: [PATCH] Staging: fsl-mc/bus: mc-bus.c: Fixed coding style issues

[gregkh]

On Fri, Sep 04, 2015 at 05:48:55PM +0000, Jose Rivera wrote:
> > -----Original Message-----
> > From: Nayeemahmed Badebade [mailto:itachi.opsrc@gmail.com]
> > Sent: Friday, September 04, 2015 12:01 PM
> > To: gregkh@linuxfoundation.org
> > Cc: Rivera Jose-B46482; Yoder Stuart-B08248; agraf@suse.de;
> > hgujulan@visteon.com; linux-kernel@vger.kernel.org
> > Subject: [PATCH] Staging: fsl-mc/bus: mc-bus.c: Fixed coding style issues
> > 
> > Fixed coding style issues where kernel types u16,u64,u32 should be
> > preferred over uint16_t,uint64_t,uint32_t
> > 
> Nayeemahmed,
> 
> Thanks for your interests in helping us clean up this coding style issue.
> However, doing this for all the files related to the MC bus driver (not just
> for one) is something that I intend to do in a future patch as
> part of the "Cleanup" item of our TODO list.
> Doing this clean up across the board for all files is preferable than 
> doing it just for this file in this patch.

Sorry, but we never postpone a change submitted by someone just because
someone says "sometime in the future we will be making much the same
change".  That's a sure way to kill productivity and stop developers
from helping you out.

If you really wanted to make this type of change, you would have done so
already, so obviously it's not a high priority.  I'll take Nayeemahmed's
patch.

greg k-h

Re: [PATCH] Staging: fsl-mc/bus: mc-bus.c: Fixed coding style issues

[Joe Perches]

On Fri, 2015-09-04 at 11:00 -0700, gregkh@linuxfoundation.org wrote:
> On Fri, Sep 04, 2015 at 05:48:55PM +0000, Jose Rivera wrote:
> > > -----Original Message-----
> > > From: Nayeemahmed Badebade [mailto:itachi.opsrc@gmail.com]
[]
> > > Fixed coding style issues where kernel types u16,u64,u32 should be
> > > preferred over uint16_t,uint64_t,uint32_t
[]
> > Thanks for your interests in helping us clean up this coding style issue.
> > However, doing this for all the files related to the MC bus driver (not just
> > for one) is something that I intend to do in a future patch as
> > part of the "Cleanup" item of our TODO list.
> > Doing this clean up across the board for all files is preferable than 
> > doing it just for this file in this patch.
> 
> Sorry, but we never postpone a change submitted by someone just because
> someone says "sometime in the future we will be making much the same
> change".  That's a sure way to kill productivity and stop developers
> from helping you out.
> 
> If you really wanted to make this type of change, you would have done so
> already, so obviously it's not a high priority.  I'll take Nayeemahmed's
> patch.

There's a problem with doing this on a file-by-file
basis for a particular subsystem/driver.

Doing so can break compilation because of differences
between header files and compilation units.

It's likely much better to do something like:

$ git ls-files -- drivers/staging/fsl-mc/*.[ch] | \
  xargs sed -r -i \
	-e 's/\buint(8|16|32|64)_t\b/u\1/g' \
	-e 's/\bint(8|16|32|64)_t\b/s\1/g'

then verify, compile, test, and submit the diff.