From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/6] perf, tools, stat: Move sw clock metrics printout to stat-shadow
Date: Fri, 4 Sep 2015 19:50:50 -0300 [thread overview]
Message-ID: <20150904225050.GE3475@kernel.org> (raw)
In-Reply-To: <1441406717-1717-2-git-send-email-andi@firstfloor.org>
Em Fri, Sep 04, 2015 at 03:45:12PM -0700, Andi Kleen escreveu:
> From: Andi Kleen <ak@linux.intel.com>
>
> The sw clock metrics printing was missed in the earlier move to
> stat-shadow of all the other metric printouts. Move it too.
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
Merging this one, letting Jiri react to the others,
- Arnaldo
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> tools/perf/builtin-stat.c | 9 ---------
> tools/perf/util/stat-shadow.c | 3 +++
> 2 files changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index a96fb5c..77e5781 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -510,15 +510,6 @@ static void nsec_printout(int id, int nr, struct perf_evsel *evsel, double avg)
>
> if (evsel->cgrp)
> fprintf(output, "%s%s", csv_sep, evsel->cgrp->name);
> -
> - if (csv_output || stat_config.interval)
> - return;
> -
> - if (perf_evsel__match(evsel, SOFTWARE, SW_TASK_CLOCK))
> - fprintf(output, " # %8.3f CPUs utilized ",
> - avg / avg_stats(&walltime_nsecs_stats));
> - else
> - fprintf(output, " ");
> }
>
> static void abs_printout(int id, int nr, struct perf_evsel *evsel, double avg)
> diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c
> index 2a5d8d7..625ab3b 100644
> --- a/tools/perf/util/stat-shadow.c
> +++ b/tools/perf/util/stat-shadow.c
> @@ -413,6 +413,9 @@ void perf_stat__print_shadow_stats(FILE *out, struct perf_evsel *evsel,
> ratio = total / avg;
>
> fprintf(out, " # %8.0f cycles / elision ", ratio);
> + } else if (perf_evsel__match(evsel, SOFTWARE, SW_TASK_CLOCK) &&
> + (ratio = avg_stats(&walltime_nsecs_stats)) != 0) {
> + fprintf(out, " # %8.3f CPUs utilized ", avg / ratio);
> } else if (runtime_nsecs_stats[cpu].n != 0) {
> char unit = 'M';
>
> --
> 2.4.3
next prev parent reply other threads:[~2015-09-04 22:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 22:45 perf, tools: Refactor and support interval and CSV metrics v4 Andi Kleen
2015-09-04 22:45 ` [PATCH 1/6] perf, tools, stat: Move sw clock metrics printout to stat-shadow Andi Kleen
2015-09-04 22:50 ` Arnaldo Carvalho de Melo [this message]
2015-09-04 22:45 ` [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing Andi Kleen
2015-09-07 11:43 ` Jiri Olsa
2015-09-07 12:14 ` Jiri Olsa
2015-09-08 16:03 ` Andi Kleen
2015-09-08 16:20 ` Jiri Olsa
2015-09-04 22:45 ` [PATCH 3/6] perf, tools, stat: Add support for metrics in interval mode Andi Kleen
2015-09-04 22:45 ` [PATCH 4/6] perf, tools, stat: Move noise/running printing into printout Andi Kleen
2015-09-04 22:45 ` [PATCH 5/6] perf, tools, stat: Implement CSV metrics output Andi Kleen
2015-09-04 22:45 ` [PATCH 6/6] perf, tools, stat: Move non counting counter printing to printout Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150904225050.GE3475@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox