public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: kan.liang@intel.com
Cc: jolsa@kernel.org, namhyung@kernel.org, adrian.hunter@intel.com,
	eranian@google.com, ak@linux.intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] perf,tools: Support new sort type --socket
Date: Fri, 4 Sep 2015 20:25:47 -0300	[thread overview]
Message-ID: <20150904232547.GJ3475@kernel.org> (raw)
In-Reply-To: <20150904230621.GH3475@kernel.org>

Em Fri, Sep 04, 2015 at 08:06:21PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Sep 04, 2015 at 07:52:55PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Fri, Sep 04, 2015 at 07:41:39PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Fri, Sep 04, 2015 at 10:45:43AM -0400, kan.liang@intel.com escreveu:
> > > > From: Kan Liang <kan.liang@intel.com>
> > > > 
> > > > This patch enable perf report to sort by processor socket
> > > > 
> > > > $ perf report --stdio --sort socket,comm,dso,symbol
> > > >  # To display the perf.data header info, please use
> > > >  --header/--header-only options.
> > > >  #
> > > >  #
> > > >  # Total Lost Samples: 0
> > > >  #
> > > >  # Samples: 686  of event 'cycles'
> > > >  # Event count (approx.): 349215462
> > > >  #
> > > >  # Overhead  SOCKET  Command    Shared Object     Symbol
> > > >  # ........  ......  .........  ................
> > > >  .................................
> > > 
> > > So this works in 'perf top' only for the first screen rendering, when it
> > > refreshes we lose the "SOCKET" header (why all caps?) and the colum
> > > stops being %03d and instead becomes %d, I am checking now.
> > 
> > Patch below fix this, but we stumble in another problem, when zooming it
> > is not eliding the SOCKET column, i.e. if we're zooming into a column,
> > it will have the same value for all entries, no use in showing it, save
> > some columns, will check that as well.
> > 
> > Will fold the fixes to the patches where the problems were introduced,
> > the feature is cool, one more zoom! :-)
> 
> One more fixed, see below, now we have another, using ESC should remove
> the last applied Zoom operation, just like for the other Zoom operations
> (DSO, thread, etc), looking at that now.

Fixed, see below, to test, press S, then d to zoom into Socket then DSO
and then press ESC to unzoom one level (the DSO in this case) then ESC
again, to unzoom the Socket one.

If you use the left arrow key it will be equivalent to ESC, but we'll
repurpose the left/right arrows for horizontal scrolling soon.

- Arnaldo

  reply	other threads:[~2015-09-04 23:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-04 14:45 [PATCH 1/5] perf,tools: add processor socket info in hist_entry and addr_location kan.liang
2015-09-04 14:45 ` [PATCH 2/5] perf,tools: Support new sort type --socket kan.liang
2015-09-04 22:41   ` Arnaldo Carvalho de Melo
2015-09-04 22:52     ` Arnaldo Carvalho de Melo
2015-09-04 23:06       ` Arnaldo Carvalho de Melo
2015-09-04 23:25         ` Arnaldo Carvalho de Melo [this message]
2015-09-04 23:26           ` Arnaldo Carvalho de Melo
2015-09-04 23:30             ` Arnaldo Carvalho de Melo
2015-09-15  7:05   ` [tip:perf/core] perf tools: Introduce new sort type "socket" for the processor socket tip-bot for Kan Liang
2015-09-04 14:45 ` [PATCH 3/5] perf,report: introduce socket-filter option kan.liang
2015-09-15  7:05   ` [tip:perf/core] perf report: Introduce --socket-filter option tip-bot for Kan Liang
2015-09-04 14:45 ` [PATCH 4/5] perf,tools: zoom in/out for processor socket kan.liang
2015-09-04 22:09   ` Andi Kleen
2015-09-15  7:06   ` [tip:perf/core] perf hists browser: Zoom in/ out " tip-bot for Kan Liang
2015-09-04 14:45 ` [PATCH 5/5] perf,test: test hists socket filter kan.liang
2015-09-15  7:06   ` [tip:perf/core] perf test: Add entry for " tip-bot for Kan Liang
2015-09-15  7:05 ` [tip:perf/core] perf tools: Add processor socket info to hist_entry and addr_location tip-bot for Kan Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150904232547.GJ3475@kernel.org \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=eranian@google.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox