From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934988AbbIEBGx (ORCPT ); Fri, 4 Sep 2015 21:06:53 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:43006 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751579AbbIEBGo (ORCPT ); Fri, 4 Sep 2015 21:06:44 -0400 Date: Fri, 4 Sep 2015 18:06:43 -0700 From: Greg KH To: Mike Dupuis Cc: gregkh@suse.de, hamohammed.sa@gmail.com, gdonald@gmail.com, mahfouz.saif.elyazal@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: rtl18192u: fix style issues in ieee80211_softmac_wx.c Message-ID: <20150905010643.GA2860@kroah.com> References: <1441407606-7951-1-git-send-email-mike.dupuis.0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441407606-7951-1-git-send-email-mike.dupuis.0@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 04, 2015 at 11:00:06PM +0000, Mike Dupuis wrote: > This is a patch to the ieee80211_softmac_wx.c file that corrects several > checkpatch.pl warnings and errors. > Signed-off-by: Mike Dupuis You need a blank line before the signed-off-by line. Also, please break this up into multiple patches, each one only doing one type of cleanup. As it is, I can't take it, sorry. thanks, greg k-h