From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751310AbbIEHcq (ORCPT <rfc822;w@1wt.eu>);
	Sat, 5 Sep 2015 03:32:46 -0400
Received: from mail-wi0-f174.google.com ([209.85.212.174]:35723 "EHLO
	mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750724AbbIEHci (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 5 Sep 2015 03:32:38 -0400
Date: Sat, 5 Sep 2015 09:32:33 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Mikko Rapeli <mikko.rapeli@iki.fi>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>
Subject: Re: [PATCH] x86/headers: Fix (old) header file dependency bug in
 uapi/asm/sigcontext32.h
Message-ID: <20150905073233.GC5817@gmail.com>
References: <1433000370-19509-1-git-send-email-mikko.rapeli@iki.fi>
 <1433000370-19509-95-git-send-email-mikko.rapeli@iki.fi>
 <20150902193453.GZ9187@lakka.kapsi.fi>
 <20150903074231.GA23098@gmail.com>
 <20150904071031.GA9187@lakka.kapsi.fi>
 <20150904085831.GA17456@gmail.com>
 <20150904121827.GB9187@lakka.kapsi.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150904121827.GB9187@lakka.kapsi.fi>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Mikko Rapeli <mikko.rapeli@iki.fi> wrote:

> > sigcontext32.h is a 64-bit only header (for compat functionality), and you are 
> > trying to build this on i386, right?
> 
> Yes, i386 32bit.
> 
> > In theory we could unify them mostly, the two structures match mostly, except that 
> > '_fpstate_ia32::padding' is named 'padding1' in _fpstate, and there's also some 
> > legacy uglies wrt. user-space sigcontext definitions.
> > 
> > So this either gets cleaned up properly, with the legacy hacks/wrappers clearly 
> > isolated, or we could state that you shouldn't build 64-bit headers in 32-bit 
> > environments.
> 
> Should the sigcontext32.h have some 32bit ifdefs maybe?

That gets ugly pretty fast.

> I assume that the exported header files should be the same for both 64 and 32
> bit i386/x86

Yes. I have written a small series cleaning up all these header problems - I'll 
send it out in a few minutes.

Thanks,

	Ingo