From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751311AbbIEIJZ (ORCPT ); Sat, 5 Sep 2015 04:09:25 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:33206 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751170AbbIEIJH (ORCPT ); Sat, 5 Sep 2015 04:09:07 -0400 Date: Sat, 5 Sep 2015 13:38:56 +0530 From: Sudip Mukherjee To: David Matlack Cc: Lior Dotan , Christopher Harrer , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , devel@driverdev.osuosl.org Subject: Re: [PATCH] staging: slicoss: remove unused variables Message-ID: <20150905080856.GA29370@sudip-pc> References: <1441372998-22760-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 04, 2015 at 11:13:00AM -0700, David Matlack wrote: > On Fri, Sep 4, 2015 at 6:23 AM, Sudip Mukherjee > wrote: > > These variables were only assigned some values but they were never used. > > > > Signed-off-by: Sudip Mukherjee > > --- > > - status = slic_upr_request(adapter, SLIC_UPR_RLSR, > > - (u32) &pshmem->linkstatus, /* no 4GB wrap guaranteed */ > > - 0, 0, 0); > > + slic_upr_request(adapter, SLIC_UPR_RLSR, > > + (u32)&pshmem->linkstatus, /* no 4GB wrap guaranteed */ > > + 0, 0, 0); > > Is status safe to ignore? status can have two value either -ENOMEM or STATUS_PEMDING. Ideally we should have handled -ENOMEM. regards sudip