From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753867AbbIENc2 (ORCPT ); Sat, 5 Sep 2015 09:32:28 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:34332 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751431AbbIENcV (ORCPT ); Sat, 5 Sep 2015 09:32:21 -0400 Date: Sat, 5 Sep 2015 21:32:52 +0800 From: Peng Fan To: Grygorii Strashko Cc: linus.walleij@linaro.org, gnurou@gmail.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] gpio: gpiolib: use devm_* API to simplify driver code Message-ID: <20150905133251.GA17774@linux-4gyl.site> References: <1440417930-15876-1-git-send-email-van.freenix@gmail.com> <55DC2997.9030705@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55DC2997.9030705@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 25, 2015 at 11:38:47AM +0300, Grygorii Strashko wrote: > On 08/24/2015 03:05 PM, Peng Fan wrote: > >Use devm_* API to simplify driver code. > > > >Signed-off-by: Peng Fan > >Cc: Linus Walleij > >Cc: Alexandre Courbot > --- > > drivers/gpio/gpiolib.c | 11 +++++------ > > 1 file changed, 5 insertions(+), 6 deletions(-) > > > >diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > >index 6bc612b..f9470b0 100644 > >--- a/drivers/gpio/gpiolib.c > >+++ b/drivers/gpio/gpiolib.c > >@@ -243,7 +243,8 @@ int gpiochip_add(struct gpio_chip *chip) > > int base = chip->base; > > struct gpio_desc *descs; > > > >- descs = kcalloc(chip->ngpio, sizeof(descs[0]), GFP_KERNEL); > >+ descs = devm_kcalloc(chip->dev, chip->ngpio, sizeof(descs[0]), > >+ GFP_KERNEL); > > ^ above will not work for every one as NOT all GPIO drivers > implemented using dev/drv model, so chip->dev could be not set > (at least it was true when I've checked it last time). > Thanks for correcting me! Regards, Peng. > > > > -- > regards, > -grygorii