From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753929AbbIETDe (ORCPT ); Sat, 5 Sep 2015 15:03:34 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:37671 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753212AbbIETDV (ORCPT ); Sat, 5 Sep 2015 15:03:21 -0400 Date: Sat, 5 Sep 2015 22:03:16 +0300 From: Mike Rapoport To: Sudip Mukherjee Cc: Greg Kroah-Hartman , Teddy Wang , Sudip Mukherjee , LKML Subject: Re: [PATCH v2 10/17] staging: sm750fb: ddk750_swi2c: rename CamelCase static functions Message-ID: <20150905190316.GC11445@zed> References: <1441354742-8648-1-git-send-email-mike.rapoport@gmail.com> <1441354742-8648-11-git-send-email-mike.rapoport@gmail.com> <20150904122607.GC9584@sudip-pc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150904122607.GC9584@sudip-pc> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 04, 2015 at 05:56:07PM +0530, Sudip Mukherjee wrote: > On Fri, Sep 04, 2015 at 11:18:55AM +0300, Mike Rapoport wrote: > > Fix the checkpatch warning about CamelCase. > > > > Signed-off-by: Mike Rapoport > > --- > This is again having too many renames. I lost track while seeing. :( > Like Greg said, please break them into separate patches. Maybe I've missed something, but I only remember that Greg asked not to add sm750_ prefix to the static functions. I beleive, that 58 changes is not too many, and it still falls under defintion of "single logical change". IMHO, splitting this patch and, e.g., renaming a function at a time won't do better > regards > sudip -- Sincerely yours, Mike.