* [PATCH] staging: most: Use NULL instead of 0 in assignment of pointer
@ 2015-08-29 11:53 Anders Fridlund
2015-09-03 16:41 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Anders Fridlund @ 2015-08-29 11:53 UTC (permalink / raw)
To: gregkh
Cc: christian.gromm, mhornung.linux, devel, linux-kernel,
Anders Fridlund
Fix sparse warning 'Using plain integer as NULL pointer' by replacing 0
with NULL in the assignment.
Signed-off-by: Anders Fridlund <anders.fridlund@gmail.com>
---
drivers/staging/most/aim-network/networking.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/aim-network/networking.c b/drivers/staging/most/aim-network/networking.c
index c8ab239..a1e1bce 100644
--- a/drivers/staging/most/aim-network/networking.c
+++ b/drivers/staging/most/aim-network/networking.c
@@ -295,7 +295,7 @@ static void most_net_rm_netdev_safe(struct net_dev_context *nd)
unregister_netdev(nd->dev);
free_netdev(nd->dev);
- nd->dev = 0;
+ nd->dev = NULL;
}
static struct net_dev_context *get_net_dev_context(
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: most: Use NULL instead of 0 in assignment of pointer
2015-08-29 11:53 [PATCH] staging: most: Use NULL instead of 0 in assignment of pointer Anders Fridlund
@ 2015-09-03 16:41 ` Greg KH
2015-09-05 19:21 ` Anders Fridlund
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2015-09-03 16:41 UTC (permalink / raw)
To: Anders Fridlund; +Cc: devel, christian.gromm, linux-kernel, mhornung.linux
On Sat, Aug 29, 2015 at 01:53:49PM +0200, Anders Fridlund wrote:
> Fix sparse warning 'Using plain integer as NULL pointer' by replacing 0
> with NULL in the assignment.
>
> Signed-off-by: Anders Fridlund <anders.fridlund@gmail.com>
> ---
> drivers/staging/most/aim-network/networking.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/most/aim-network/networking.c b/drivers/staging/most/aim-network/networking.c
> index c8ab239..a1e1bce 100644
> --- a/drivers/staging/most/aim-network/networking.c
> +++ b/drivers/staging/most/aim-network/networking.c
> @@ -295,7 +295,7 @@ static void most_net_rm_netdev_safe(struct net_dev_context *nd)
>
> unregister_netdev(nd->dev);
> free_netdev(nd->dev);
> - nd->dev = 0;
> + nd->dev = NULL;
> }
>
> static struct net_dev_context *get_net_dev_context(
> --
> 1.9.1
Why did you resend this patch again?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: most: Use NULL instead of 0 in assignment of pointer
2015-09-03 16:41 ` Greg KH
@ 2015-09-05 19:21 ` Anders Fridlund
2015-09-05 20:03 ` Greg KH
2015-09-22 13:07 ` Dan Carpenter
0 siblings, 2 replies; 7+ messages in thread
From: Anders Fridlund @ 2015-09-05 19:21 UTC (permalink / raw)
To: Greg KH; +Cc: devel, christian.gromm, linux-kernel, Michael Hornung
I resent it since no one responded to it for 10 days. From what I came
to understand that is the common practice. If that is not the case I'm
sorry (and please let me know so I don't do it again).
Cheers,
Anders Fridlund
On Thu, Sep 3, 2015 at 6:41 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sat, Aug 29, 2015 at 01:53:49PM +0200, Anders Fridlund wrote:
>> Fix sparse warning 'Using plain integer as NULL pointer' by replacing 0
>> with NULL in the assignment.
>>
>> Signed-off-by: Anders Fridlund <anders.fridlund@gmail.com>
>> ---
>> drivers/staging/most/aim-network/networking.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/most/aim-network/networking.c b/drivers/staging/most/aim-network/networking.c
>> index c8ab239..a1e1bce 100644
>> --- a/drivers/staging/most/aim-network/networking.c
>> +++ b/drivers/staging/most/aim-network/networking.c
>> @@ -295,7 +295,7 @@ static void most_net_rm_netdev_safe(struct net_dev_context *nd)
>>
>> unregister_netdev(nd->dev);
>> free_netdev(nd->dev);
>> - nd->dev = 0;
>> + nd->dev = NULL;
>> }
>>
>> static struct net_dev_context *get_net_dev_context(
>> --
>> 1.9.1
>
> Why did you resend this patch again?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: most: Use NULL instead of 0 in assignment of pointer
2015-09-05 19:21 ` Anders Fridlund
@ 2015-09-05 20:03 ` Greg KH
2015-09-22 13:07 ` Dan Carpenter
1 sibling, 0 replies; 7+ messages in thread
From: Greg KH @ 2015-09-05 20:03 UTC (permalink / raw)
To: Anders Fridlund; +Cc: devel, christian.gromm, linux-kernel, Michael Hornung
On Sat, Sep 05, 2015 at 09:21:58PM +0200, Anders Fridlund wrote:
> I resent it since no one responded to it for 10 days. From what I came
> to understand that is the common practice. If that is not the case I'm
> sorry (and please let me know so I don't do it again).
That's fine to do, but at least say why you are resending it in the area
under the --- line, otherwise we have no idea what is going on.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: most: Use NULL instead of 0 in assignment of pointer
2015-09-05 19:21 ` Anders Fridlund
2015-09-05 20:03 ` Greg KH
@ 2015-09-22 13:07 ` Dan Carpenter
1 sibling, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2015-09-22 13:07 UTC (permalink / raw)
To: Anders Fridlund
Cc: Greg KH, devel, christian.gromm, linux-kernel, Michael Hornung
On Sat, Sep 05, 2015 at 09:21:58PM +0200, Anders Fridlund wrote:
> I resent it since no one responded to it for 10 days. From what I came
> to understand that is the common practice. If that is not the case I'm
> sorry (and please let me know so I don't do it again).
>
10 days is too short. Especially since the merge window was open.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] staging: most: Use NULL instead of 0 in assignment of pointer
@ 2015-08-19 22:12 Anders Fridlund
2015-09-03 16:41 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Anders Fridlund @ 2015-08-19 22:12 UTC (permalink / raw)
To: gregkh
Cc: christian.gromm, mhornung.linux, devel, linux-kernel,
Anders Fridlund
Fix sparse warning 'Using plain integer as NULL pointer' by replacing 0
with NULL in the assignment.
Signed-off-by: Anders Fridlund <anders.fridlund@gmail.com>
---
drivers/staging/most/aim-network/networking.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/aim-network/networking.c b/drivers/staging/most/aim-network/networking.c
index c8ab239..a1e1bce 100644
--- a/drivers/staging/most/aim-network/networking.c
+++ b/drivers/staging/most/aim-network/networking.c
@@ -295,7 +295,7 @@ static void most_net_rm_netdev_safe(struct net_dev_context *nd)
unregister_netdev(nd->dev);
free_netdev(nd->dev);
- nd->dev = 0;
+ nd->dev = NULL;
}
static struct net_dev_context *get_net_dev_context(
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: most: Use NULL instead of 0 in assignment of pointer
2015-08-19 22:12 Anders Fridlund
@ 2015-09-03 16:41 ` Greg KH
0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2015-09-03 16:41 UTC (permalink / raw)
To: Anders Fridlund; +Cc: christian.gromm, mhornung.linux, devel, linux-kernel
On Thu, Aug 20, 2015 at 12:12:51AM +0200, Anders Fridlund wrote:
> Fix sparse warning 'Using plain integer as NULL pointer' by replacing 0
> with NULL in the assignment.
>
> Signed-off-by: Anders Fridlund <anders.fridlund@gmail.com>
> ---
> drivers/staging/most/aim-network/networking.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/most/aim-network/networking.c b/drivers/staging/most/aim-network/networking.c
> index c8ab239..a1e1bce 100644
> --- a/drivers/staging/most/aim-network/networking.c
> +++ b/drivers/staging/most/aim-network/networking.c
> @@ -295,7 +295,7 @@ static void most_net_rm_netdev_safe(struct net_dev_context *nd)
>
> unregister_netdev(nd->dev);
> free_netdev(nd->dev);
> - nd->dev = 0;
> + nd->dev = NULL;
> }
>
> static struct net_dev_context *get_net_dev_context(
> --
> 1.9.1
Someone sent this patch before you did, sorry :(
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-09-22 13:07 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-29 11:53 [PATCH] staging: most: Use NULL instead of 0 in assignment of pointer Anders Fridlund
2015-09-03 16:41 ` Greg KH
2015-09-05 19:21 ` Anders Fridlund
2015-09-05 20:03 ` Greg KH
2015-09-22 13:07 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2015-08-19 22:12 Anders Fridlund
2015-09-03 16:41 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox