From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753672AbbIEUat (ORCPT ); Sat, 5 Sep 2015 16:30:49 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:46827 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753268AbbIEUal (ORCPT ); Sat, 5 Sep 2015 16:30:41 -0400 Date: Sat, 5 Sep 2015 22:22:57 +0200 From: Andrew Lunn To: Michael Welling Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: phy: Handle postive return codes in phy_connect Message-ID: <20150905202257.GE6040@lunn.ch> References: <1441476089-22108-1-git-send-email-mwelling@ieee.org> <20150905191840.GC6040@lunn.ch> <20150905194400.GA1687@deathstar> <20150905194755.GD6040@lunn.ch> <20150905202125.GA6250@deathstar> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150905202125.GA6250@deathstar> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > It might not be an ERRNO. E.g. https://lkml.org/lkml/2015/9/3/534 > > fixed a bug where a positive value is returned which is not an > > indication of an error. > > It appears that I have stumbled upon the exact same issue as is fixed in > the patch above. Ah, sorry. I put that bug there :-( The fix should be making its way into the kernel soon. Andrew