linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: geert@linux-m68k.org
Cc: Woojung.Huh@microchip.com, linux-usb@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lan78xx: Fix ladv/radv error handling in lan78xx_link_reset()
Date: Sun, 06 Sep 2015 19:47:18 -0700 (PDT)	[thread overview]
Message-ID: <20150906.194718.1930392629598351441.davem@davemloft.net> (raw)
In-Reply-To: <1441363648-20738-1-git-send-email-geert@linux-m68k.org>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: Text/Plain; charset=iso-8859-7, Size: 879 bytes --]

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Fri,  4 Sep 2015 12:47:28 +0200

> net/usb/lan78xx.c: In function ¡lan78xx_link_reset¢:
> net/usb/lan78xx.c:1107: warning: comparison is always false due to limited range of data type
> net/usb/lan78xx.c:1111: warning: comparison is always false due to limited range of data type
> 
> Assigning return values that can be negative error codes to "u16"
> variables makes them positive, ignoring the errors.  Hence use "int"
> instead.
> 
> Drop the "unlikely"s (unlikely considered harmful) and propagate the
> actual error values instead of overriding them to -EIO while we're at
> it.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied, thanks.
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

      reply	other threads:[~2015-09-07  2:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-04 10:47 [PATCH] lan78xx: Fix ladv/radv error handling in lan78xx_link_reset() Geert Uytterhoeven
2015-09-07  2:47 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150906.194718.1930392629598351441.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Woojung.Huh@microchip.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).