From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753487AbbIGCr0 (ORCPT ); Sun, 6 Sep 2015 22:47:26 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:41030 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752950AbbIGCrV (ORCPT ); Sun, 6 Sep 2015 22:47:21 -0400 Date: Sun, 06 Sep 2015 19:47:18 -0700 (PDT) Message-Id: <20150906.194718.1930392629598351441.davem@davemloft.net> To: geert@linux-m68k.org Cc: Woojung.Huh@microchip.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] lan78xx: Fix ladv/radv error handling in lan78xx_link_reset() From: David Miller In-Reply-To: <1441363648-20738-1-git-send-email-geert@linux-m68k.org> References: <1441363648-20738-1-git-send-email-geert@linux-m68k.org> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 06 Sep 2015 19:47:21 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t872m0U0014600 From: Geert Uytterhoeven Date: Fri, 4 Sep 2015 12:47:28 +0200 > net/usb/lan78xx.c: In function lan78xx_link_reset: > net/usb/lan78xx.c:1107: warning: comparison is always false due to limited range of data type > net/usb/lan78xx.c:1111: warning: comparison is always false due to limited range of data type > > Assigning return values that can be negative error codes to "u16" > variables makes them positive, ignoring the errors. Hence use "int" > instead. > > Drop the "unlikely"s (unlikely considered harmful) and propagate the > actual error values instead of overriding them to -EIO while we're at > it. > > Signed-off-by: Geert Uytterhoeven Applied, thanks. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I