From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751636AbbIFDO4 (ORCPT ); Sat, 5 Sep 2015 23:14:56 -0400 Received: from mail-by2on0118.outbound.protection.outlook.com ([207.46.100.118]:10068 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750878AbbIFDOr (ORCPT ); Sat, 5 Sep 2015 23:14:47 -0400 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=freescale.com; Date: Sun, 6 Sep 2015 10:02:41 +0800 From: Peter Chen To: Roger Quadros CC: , , , , , , , Subject: Re: [PATCH v4 1/9] usb: dwc3: add dual-role support Message-ID: <20150906020240.GB4914@shlinux2> References: <1441203864-15786-1-git-send-email-rogerq@ti.com> <1441203864-15786-2-git-send-email-rogerq@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1441203864-15786-2-git-send-email-rogerq@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD009;1:uhOVJsbsVTaFgZUCnbV1M4F5Q2zWhO2wFqzDdjguGFY9iArTY+EScHZ2doCfKpI19jZ3VODKWRO01omsG9iKiUsG83XcRbJBgCgkFCTCEn5aD8+H21kQ3baCrv7nyzLC/IpXgAlZs2wa0Kflk7BdSr0JczoyqRtw4bj91KiBZ3ukZdFi01dajzAhbvw1kQZc0y9AR6yu1sRgv0wvaVO61iAtjsnZ44MFx7QOX7qYRg6IjB47H3WOLKx6a4DIHzw9eSKq0B3CoZKNkNioMgOE46bcC5H73NmbNEt8jhKgZzPfYe7Hc/A5IGdKhDRLqj5eVg0nqzNRuoA6R8uy5X+ID4vRp81fJK2VvYZebVdYH9b6D+lg2H7q0ZART9a12ds1rmQSxbacFaZmU5/6nzv7EQ== X-Forefront-Antispam-Report: CIP:192.88.158.2;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1109001)(339900001)(24454002)(199003)(189002)(46406003)(5007970100001)(104016003)(85426001)(33716001)(92566002)(62966003)(83506001)(23726002)(105606002)(77156002)(87936001)(106466001)(5001830100001)(97756001)(68736005)(33656002)(76176999)(189998001)(50466002)(2950100001)(47776003)(54356999)(69596002)(86362001)(4001350100001)(81156007)(97736004)(6806004)(50986999)(110136002)(5001860100001)(46102003)(4001540100001)(77096005)(5001960100002)(64706001)(5001920100001);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR0301MB1220;H:az84smr01.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB1220;2:q7vpY6IOfX7sXClr6DT6CLIqUsG22d2LamZaRnne52KKoRvgoZv+T9fsC6IubyeUSXhbJBnRho2MvwrHcH+G/V5aY+Uskc6+Kx1owFJjhqj8jtEtl3+KkvPN3It2rEUKwahxzUWKIoHvd8t6dYAJi1dY2pykW0aHf9CvFpcbBcs=;3:DmohLa9Vf2Kit8DQNTtuAh+1uZOv+RUnU85z5ML2rE6RQlupYdXwB7Ecq5F2GvsdA38kzR+wuGd2xGPbO4PftKbckhF5NqknfdHxMsRaysK4uCO425hUL383TvcDE0niQNzxZgwVwiKSEp1BSgNHyHCL83NE/YHRjVou0+r4edp2AogzI/hWBpDNBaceBz1AdJmeVPIBh3NaoQdhq8pDTmANzTOGRHoN3hwbsu2L2jo=;25:nx/iQu8eZfsE+FKNfSqOWsx9wpfIzQCEp1jgQO9UEUgMMJ88CImeL1CE8enuVQ8+JCz2cKHi+0LkiNax7TDdIw+fs9UPKuRqSQq3Rcq+J4+oL038aGrns54RUUwEEWUAPoNB8/ON6Kf29qFEmBR2SL+QMOXEz7Tparw8EnQ4EcslilawV93yQCz18RvtuLednS9iKYhVetiJmmCqc8HCqU7acJE7qvFuMlgtFmt+rnkFgxjUyMW6lGnb2j3F+NNp+2Lbyl+H2kBTkyP03w9CJg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0301MB1220; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB1220;20:0aD55GN/EMaym+jYYbFvTEGm51xElMWx8jvFEy8uPfYrcz7TA0ZZAHwneKZwaAoK6NEiJ1itbPovZzECA1pImBOL372mKjZCeue/XlcnHkjmfin5QiybmwEX+FQwsCzAwy8VJRvjhEnI7u9dqN4NiI+KvkveBWYoizpUrRv6b3jEBk0jVNiTyMXqeJETlJe/oYnPbBumsb9sro6AienVfMZ35mty3W9ztg91+iybkPpVb1cchjXKj2DSPIhelaqk3+4/ffR46BbhLuSfSjlxKPTAUjq9eAtGplsWrN/XORTaXHx7xQznCFLi6k0ptm6BhQBZuB5eyKCKdwsfvtroHPTfROwtjKjwpj3mTRupwZo=;4:RVNbX588bRl1XsdhtU1/uSvY0LwaOZ8z2nJscwwuxGQh3PdTHtXgKn9IKytGlAe5zlUfWhgMsZeTsNIyiB/2536eORrWzIbu7U4W/IVUgYXSK+sjpYomSH5+C6hA8ET5KtV7K8YvywzaluiPpK3ogJ6bTcd5GVM7ILKx9LJR898s3TX3m0Ol+1zNvqRrWWvF0w3pqk26tlDErOUpwsKJUDm6dFa71tr25OOHwppkU0X+vg1X5WYnxliZG3isT9JgZfnwzDr6flOFQ2CKrGLx9qQCjdCnN1I6wOKGuy05nRiNUnScH9MlZdGk0+3ZrNPG X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:BN3PR0301MB1220;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0301MB1220; X-Forefront-PRVS: 06911FE69E X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN3PR0301MB1220;23:XYGi2Ft5P8d8Np+9YZPay36655gMK/Nz/TEOE+a?= =?us-ascii?Q?bI0NH7Z7YvaAveT9E/gA11eRdaMaQcnzJLng0OWTAC5b1K3tOi3+Kgp0uVk5?= =?us-ascii?Q?jrROX9ymHWd/99RF/N4j1RaKnSAZx6XKMtaqCfKjeNYI31D86wOtukhTABMG?= =?us-ascii?Q?EHRLSLHBCNJtL69cOvqH2lex3uWoADmKggeo0Fen3sr4N+7oREHNoJFkyvf8?= =?us-ascii?Q?ZvLbGy2fvL4gyqJhfPoGLqc4ticDwZPkJdTVcwZwsBO3AhVQG18o688uVPo5?= =?us-ascii?Q?UGHo6vB71l2tQwjfLD3gXB7qxYgOpm6heV+4gYDUoWIJElIOjwzE3jagqgjR?= =?us-ascii?Q?mRgXVp462tTarmAmHIClKW7+jhYvqJG8WJO13eCWk4gKzWhesdH3R01Yje+V?= =?us-ascii?Q?/pngbIdtKiMzdyKwwE4YGkrQH13lnmBDQYXwL/aC2C7MeHGHHkWlOaac3gqk?= =?us-ascii?Q?pSDj6zSaHpCUxrTU33gGshpJaEDDMfECb8ym+NX8o7AWMHlb3N8Aob9rZiEi?= =?us-ascii?Q?20cY2IUMQgp0Ctxnr4DQlZBjSNm+Cbh2uOBGiSOE6qkyvOBNkbkjqvWxKPT5?= =?us-ascii?Q?doYuxHg8hbfoGtwWPZmGRqIQcjb5hokPrq4yXqPgfn56jKLT0+36fnXx0miW?= =?us-ascii?Q?ZpE2SxHzAZLzqpIj8UfnLUhkLc4S1Qz2V+B9cm0VlonDZr0L4dibOvO3nSyR?= =?us-ascii?Q?ikjB8To7wfSj23QQCapqzYpCO2xH5vbOpVof0qKU9pZdb3YyW0Xxn9jIXDh0?= =?us-ascii?Q?1WsyAsjzb4+mPFHZjlD9Bwj9J8LVggiYmroqVLD6S6mUBR1jnsVqwY2HpHWC?= =?us-ascii?Q?ZSsHxNnYG8rhwG32AEcI/osfK4YfXOYqrVlLcM0zXDi45Y8/ZjEH3pKMpCRu?= =?us-ascii?Q?mmttOYB33I/cogRps026lgZR8uq863h6L786F7Yo9YSFuE5WAGaYf2/h52sS?= =?us-ascii?Q?Kmt1Z7N7WSCyDFXdatn72em3ciaOZnjqXLZGl4fcc0gLx8K9oNvNcpKFW3ZK?= =?us-ascii?Q?xSnulf/3z9MBy+JDnKbxTa+btpToryH7SmdAoR7VPkXhNHko4U/HMl/RIDDK?= =?us-ascii?Q?07frHsiApSbqkopkCyqjZ0mhGbjGt9RorKTZIadRBqUKbYozgOUsHe1qDUNh?= =?us-ascii?Q?P+mwWo+yb1PSAvHwfH7jsJ1p8PjLBJOeCBIj1AD7G5zpCn620u4Iyj5cvYsO?= =?us-ascii?Q?sGlfvVTCb2PMSV7tjpjw3VV0lHGm9mJRsSLN0?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB1220;5:FubQuXZ7n39Gw+rwdzpk0EFL1LOVqu60DFuuXoRPVn46HLqjPV/1Q8xBt1yAciCsanYf+fpyRqWt07sA4o+KIfzQ4kOMusou/klIo1qg6GUs38/BzFqfsMiMBVF1BI3EFK6eKGANb1MFOSv78o8g4Q==;24:5P9uui//YP9dEu9DSXFG4KFvg40hsdgOvktUMqUlloduVKyjpXsGFLRKvGr6RuEQcfk4cdorlCg9Dd9e99XX8WdCeC3NBI8EZMBkJJHKFdY=;20:x4km580jsn6o2Zr53Tb+f6xKx3+X3aw03K1vp4pe/nxAATo7zm6ER5HgtDl2TPB65a+39Y7igDW63XquZzmKXQ== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2015 03:14:43.8212 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0301MB1220 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 02, 2015 at 05:24:16PM +0300, Roger Quadros wrote: > Register with the USB OTG core. Since we don't support > OTG yet we just work as a dual-role device even > if device tree says "otg". > > + > +static int dwc3_drd_init(struct dwc3 *dwc) > +{ > + int ret, id, vbus; > + struct usb_otg_caps *otgcaps = &dwc->otg_config.otg_caps; > + > + otgcaps->otg_rev = 0; > + otgcaps->hnp_support = false; > + otgcaps->srp_support = false; > + otgcaps->adp_support = false; > + dwc->otg_config.fsm_ops = &dwc3_drd_ops; > + > + if (!dwc->edev) { > + dev_err(dwc->dev, "No extcon device found for OTG mode\n"); > + return -ENODEV; > + } > + Do All dwc3 platforms id/vbus need to get through extcon? Do the SoCs have id/vbus pin? -- Best Regards, Peter Chen