From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751349AbbIFDcx (ORCPT ); Sat, 5 Sep 2015 23:32:53 -0400 Received: from mail-by2on0128.outbound.protection.outlook.com ([207.46.100.128]:2333 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750844AbbIFDcq (ORCPT ); Sat, 5 Sep 2015 23:32:46 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=freescale.com; Date: Sun, 6 Sep 2015 10:20:40 +0800 From: Peter Chen To: Felipe Balbi CC: Roger Quadros , , , , , , , Subject: Re: [PATCH v4 5/9] usb: dwc3: core: make dual-role work with OTG irq Message-ID: <20150906022040.GC4914@shlinux2> References: <1441203864-15786-1-git-send-email-rogerq@ti.com> <1441203864-15786-6-git-send-email-rogerq@ti.com> <20150902144338.GG8299@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150902144338.GG8299@saruman.tx.rr.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD026;1:sGCD8+MGx/MtAj+Y80Sk+hN0PmWlLLizgiGDTwWd3IkCPUrpVoiKBCPsbSNhQCmjVc1XvT7hOTUgrN9K2yeRRoVQlxHO9MUcCqPGpNcVgLtMWBq/JSxGlWRtblYrArC04tkIsIu9uy6HXLoggWBihsMaTH0t7QvrBem8trTSU16EhGt2pqw5tX7tvZAxD6MfMSHMn4ybz22OZ5cTOz40gUtuWdd56B3LA7HjiwX3FoIRIlme/490BSozrqX28Yx0zzHoIzstU5zGQeMybMb2lBEQdJwn4gfhABu1eEeP+Gy9hM74bAnkidnuU52/u5dU0PFsvl+Q7i5wP/cr5cMUHeKAyGpjm+98eibbVLjhl1sYcsvj8hNFN3Dv9sZJexNMg/YJRHH+UoICdeXZesI/sQ== X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1109001)(339900001)(189002)(199003)(24454002)(86362001)(77096005)(92566002)(5001960100002)(105606002)(5007970100001)(6806004)(33716001)(64706001)(5001830100001)(2950100001)(5001860100001)(50466002)(33656002)(106466001)(46406003)(68736005)(189998001)(110136002)(47776003)(97756001)(87936001)(4001350100001)(83506001)(81156007)(85426001)(4001540100001)(97736004)(46102003)(77156002)(76176999)(62966003)(23726002)(50986999)(104016003)(54356999);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR0301MB1221;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB1221;2:vRUtgU+eps9QVHmVIVevV96ckDn8TvWBhUajSZyxnbQECNX5pa03XumNruUA/mQpbLjtwZ8nfMKf3APAL4S5LzB+mOUs6hzCYyh1bYvtORGPoTtNMW0HtSVdgj6yORGQnO6CF+b7sN4B0t3QXflUHWlYoDDD/nCjABAKyuKPaDU=;3:SbqcliezHG+dsWvgfDFpXu/ovU5kL6wtW4sVm2Ye5oMm0wQK1r+KTofACn3mDrg/I3dGaGG8JV9mHFFpiF8swJmEVDgNiVVA6h2oL2VpZvxDXQ+dU7eEOXYA5WuikmNJ2XNgId8ElHgqn18HjBs1oy+EmsAdS935EMfit+LnDP6HAmvr4nKWfG/hNAkjjPjAmEpEG7v2DR5Ao16tBTeHpuw7IQ6bulkwECk0crCbEeM=;25:nY9NRlp/wOxZPkelHpsqt5CTMahMN8LvplNzoXKuRVU2wTkm0L1caltYLVNP9FsuQ3fzHsPCs+Vi4uVsfNao9ZY8nFI9LyqpgPGTmGG1JY+y0VXpcZ4CLtwd0Ktqfx/i/6da5hHcV/VdUfQDxHHTVMazQuynIqnjcZ7pOi1EJ+lXkGj4dbE7uShAPO5OZpFZf6Hnv1KV4uPP9mNcmJUTyYK3lnRxt6EdxodPwr7+pImjVFdN7HEdJJt1pYxcu/0D X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0301MB1221; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB1221;20:HV+tBk09/u179gDMXS2bD2rodrbcfmzXJRq6HSILTcI8fjXSI/GOorabCc9iBBJjvwBcmIEbFVJMt10k8cbOqsq/aIKs55wG2iN6uwBIrqVo+MxfTan7F8TPOlhW2b4Z9Z6FiKsIYYJgXwvJZFV45asmEVyAutZbnRq3RiWJOBho3fXMyDY3KNiUSInC/RKlS6TVE0RPURSs5PXYWrnqYB6RmYHh/dBlA5cEk8Ax0MuD8G9zxm5MpH21/qHyXva3QveCdwcH+ZBku7s8utleNEAR/rOw5HX9M/TxK+clZ7tBRelG8WHhc2uSt1wb6YnvnreJ2nlZmG8FPA8TGVFOZKCuivqnnVgVvzK4MT1fUA4=;4:QAvqgvX6OVhTOSyKMhPL2mYGlSIuMpKb0u4929dcSH8s3q+H7TZdP5Y5JFEFGWEKJFDWmySUDJ8CZWZfOHPMCBdHa/5FTZrLBxKgo36Hugs66pGMXyLgC99jyhT6kPQ9qbdVebe0MwrCIm1YF7PCFsIMs+fk17cTEG52kzKsxz8ekGcSiqd+deYpFcvjcK4fFY/zEPJ8VxNVfSD6KDQPp0INmGtC0z5mPRcLymWfYSzdqagc5jNmfBwZs9wJW1xtCb0jwo46bgdPCjca1x+GtS6LeXW8IpQmp2g2zIdCG2LOOov/8pp3FvXPCRoXukuu X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:BY1PR0301MB1221;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0301MB1221; X-Forefront-PRVS: 06911FE69E X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY1PR0301MB1221;23:RLHpfi7mZ+l43ak2VT7p/cXdeSGBz86flhnLXnp?= =?us-ascii?Q?WBT5GfkkxeXS+5kYM3T5goDP3GaYmCE9eILR46ULEBLjXuidxebYifFSKggg?= =?us-ascii?Q?1QNdtBHpQrlzVx5+mJxboxmNQS/6a1FALocl5MgPcEukVGtpefpCy8+t+Oe/?= =?us-ascii?Q?Cb3uUWYUwK6smJjZhI5dQEE5ZbAjUepXVPZsilzYf+FtxLYpP6PbdvrQDftO?= =?us-ascii?Q?MyWfYDCh83HOg217jrbJv6lf++colgummKMhd1tzyZB1oJjCZhBOSd5ZihMl?= =?us-ascii?Q?zBh0rnwBkVeSv6GsZHR4jQFcUiJOk5LGuZvUM7g48LiclQUIcHTfYJewQXek?= =?us-ascii?Q?mYCDxgsMZEqQqnvpcOQFpd3jKn53y0fssGdcJP6cYHME1G8DH1EPck1HdDRJ?= =?us-ascii?Q?Cb3nvJytx5n2E6SLU+Mowab45JDZYFLNViT+D0IhNTHIgZ8VJAMpJzXCYfD3?= =?us-ascii?Q?LWCVbz9eEuv3ZLAZOLj3xblVyF+0lkNaOSTq92AtXtBSwW8lqMIFEH/azAnq?= =?us-ascii?Q?B1xgR7PD59GofOxNfyiZ8jb3HeSPknIKlPJkKs7gGQD5ojbauMAkAONkk66Y?= =?us-ascii?Q?3bSXBHnptFrerYTE3WabS8ydMaRBAU2wGiu2BPZPCx2nWvholcvYnbvQ3pFf?= =?us-ascii?Q?tr+k2EGWx7W0Hu9PH66dpvPzE1/VJ9locJ5Yai0k9+cADB/r3PXS/+4vFahb?= =?us-ascii?Q?JTN2zpQe5ZsDlpHq4OOMfKcYFua0J/6uf3Q4DAjvxdC1NQOfa4NRJz4Roj0D?= =?us-ascii?Q?NsEaFwpCEsKbuAFjgMOsC52DDdQj9iMWvIg31SjUnRDKKMnPBL/h+wKzkkUk?= =?us-ascii?Q?rN78dIVxwG0gvqyY1163fEpvUvCbVKSs40V4rWUBoyhRY2A32RB+9Yi1rCg6?= =?us-ascii?Q?GQ+TaVizLgihfgsE6d3GWk2wBxkUdb8DOTsdXcW85C6aMLzlLW3D+hstw7x/?= =?us-ascii?Q?GSZiYs0lDbfrYzDiaJnnDnVqazgW/6X4KX4dG8MJkAoWBDHkZ+t3R525s/R2?= =?us-ascii?Q?xolFEiu40E+Wd75z7g2ooFnv3I5Q8nL9MPgKjwX0m6CGURqGaenz/HmppRvo?= =?us-ascii?Q?bgNJBe20jFUsTG3EHjRdrLr8I+qmCayMXYqQLgYLZx6Wrp/CLZS8DOjpt4ni?= =?us-ascii?Q?mNr5OtmSdAsOqqg6YwaYw79aihz4XmBlWOPfYNe9fSA31Odh9o2M6dw=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB1221;5:tredSnSBqSqH75fw6vbauz+XZZtJf/2qeHMKs8B+FP09el8Kcbcf0XInlrRCMPm++GMzB+cfdJJc0p+r+A7kUUf/CAHt/BcYxJmQvlRksKG00mblJ/0ut0LEYTuOuRjXKMOJ6aLfVdXcpK1Uv6g40Q==;24:3yD0MZSYvqH9axwKTM0A8xVpEHFyT0/cMnQothiKLnK+pvySkPw3Kng0NBgs/uXEalN650B4HfNrUUmcsyAUmbEqSlC7nEWlhV/Nzpp8D8I=;20:s8GAyMoXUBOAq+3q2vUIBM8Aw3ZnJ3EGwvFTyJLoH72X2JNppdYOPlNMwSmB4neUPBPSi9pnW+T1vigzDauAnA== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2015 03:32:43.9766 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0301MB1221 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 02, 2015 at 09:43:38AM -0500, Felipe Balbi wrote: > Hi, > > > + > > +static irqreturn_t dwc3_otg_irq(int irq, void *_dwc) > > +{ > > + struct dwc3 *dwc = _dwc; > > + irqreturn_t ret = IRQ_NONE; > > + u32 reg; > > + > > + spin_lock(&dwc->lock); > > this seems unnecessary, we're already in hardirq with IRQs disabled. > What sort of race could we have ? (in fact, this also needs change in > dwc3/gadget.c). > Is it possible the kernel process is accessing the content you will access? -- Best Regards, Peter Chen