From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752503AbbIFHXT (ORCPT ); Sun, 6 Sep 2015 03:23:19 -0400 Received: from mail.kernel.org ([198.145.29.136]:58848 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750964AbbIFHXI (ORCPT ); Sun, 6 Sep 2015 03:23:08 -0400 Date: Sun, 6 Sep 2015 15:22:45 +0800 From: Shawn Guo To: Alison Wang Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jason.jin@freescale.com Subject: Re: [PATCH] ARM: ls1021a: add platform notifier for dma-coherent requirement Message-ID: <20150906072245.GG30746@tiger> References: <1438941719-38350-1-git-send-email-b18965@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438941719-38350-1-git-send-email-b18965@freescale.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 07, 2015 at 06:01:59PM +0800, Alison Wang wrote: > This patch adds platform notifier for dma-coherent requirement. > Structure arm_coherent_dma_ops is used instead of arm_dma_ops. > > Signed-off-by: Alison Wang > --- > arch/arm/mach-imx/mach-ls1021a.c | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/arch/arm/mach-imx/mach-ls1021a.c b/arch/arm/mach-imx/mach-ls1021a.c > index b89c858..6bfc71b 100644 > --- a/arch/arm/mach-imx/mach-ls1021a.c > +++ b/arch/arm/mach-imx/mach-ls1021a.c > @@ -7,10 +7,39 @@ > * (at your option) any later version. > */ > > +#include > +#include > #include > > #include "common.h" > > +static int ls1021a_platform_notifier(struct notifier_block *nb, > + unsigned long event, void *__dev) > +{ > + struct device *dev = __dev; > + > + if (event != BUS_NOTIFY_ADD_DEVICE) > + return NOTIFY_DONE; > + > + if (of_device_is_compatible(dev->of_node, "fsl,etsec2")) > + set_dma_ops(dev, &arm_coherent_dma_ops); Why cannot you simply add property dma-coherent for etsec2 node in device tree? In that case, of_dma_configure() will just do the job from of_platform_device_create_pdata(). Shawn > + else if (of_property_read_bool(dev->of_node, "dma-coherent")) > + set_dma_ops(dev, &arm_coherent_dma_ops); > + > + return NOTIFY_OK; > +} > + > +static struct notifier_block ls1021a_platform_nb = { > + .notifier_call = ls1021a_platform_notifier, > +}; > + > +static void __init ls1021a_init_machine(void) > +{ > + bus_register_notifier(&platform_bus_type, &ls1021a_platform_nb); > + > + of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); > +} > + > static const char * const ls1021a_dt_compat[] __initconst = { > "fsl,ls1021a", > NULL, > @@ -18,5 +47,6 @@ static const char * const ls1021a_dt_compat[] __initconst = { > > DT_MACHINE_START(LS1021A, "Freescale LS1021A") > .smp = smp_ops(ls1021a_smp_ops), > + .init_machine = ls1021a_init_machine, > .dt_compat = ls1021a_dt_compat, > MACHINE_END > -- > 2.1.0.27.g96db324 >