From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753563AbbIGCgu (ORCPT ); Sun, 6 Sep 2015 22:36:50 -0400 Received: from mail-bl2on0146.outbound.protection.outlook.com ([65.55.169.146]:13035 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753521AbbIGCgs (ORCPT ); Sun, 6 Sep 2015 22:36:48 -0400 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=freescale.com; Date: Mon, 7 Sep 2015 09:24:38 +0800 From: Peter Chen To: Roger Quadros CC: , , , , , , , , , , , Subject: Re: [PATCH v4 04/13] otg-fsm: move usb_bus_start_enum into otg-fsm->ops Message-ID: <20150907012437.GH4914@shlinux2> References: <1440422484-4737-1-git-send-email-rogerq@ti.com> <1440422484-4737-5-git-send-email-rogerq@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1440422484-4737-5-git-send-email-rogerq@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD027;1:g6xk5sFYKTBui1VpTFrCVUddtLrQv4+wPJ0z9rFRllP6+fpCOe2n89bs5tp2UkzQxw4e1j7pyZa1d6HwurSS/oaT4CvFu3X75Wr1oa2/ePpcLxHhz6SKIemGd5NY9n1uGh1zz9shXaVjOQcHCEDqMIEDXHN5Ikx7Di/XDkunlOyA36RZaYIVCaOoUlDh9XPCnGCAM/eELUjN+sJ+1aUNIOPqSOfG+qJGApTKUgPOb4k++7VzotiWnjxd4ZcPQXLY4nxALltX+91BV/eNPtokpiITuIUacgjfa0N3xAMPZ5s9VoMwXhqXDM8TZZpmCuevnHo0IUKwDpKSQjCRh5uTBmKLdTd4UqFOrR7dzF/ZwRvfxOvCRv/8v2qIv9swcm1S4k9LLSUkXBmjL3f/p0XM7UTbim9rcrPzEAkfkWipVQw= X-Forefront-Antispam-Report: CIP:192.88.158.2;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1109001)(339900001)(199003)(189002)(24454002)(19580405001)(19580395003)(54356999)(106466001)(50986999)(33656002)(4001540100001)(69596002)(83506001)(6806004)(85426001)(97736004)(76176999)(5001830100001)(5001860100001)(5007970100001)(62966003)(4001350100001)(77156002)(46102003)(50466002)(77096005)(68736005)(104016003)(87936001)(64706001)(189998001)(86362001)(81156007)(47776003)(92566002)(33716001)(97756001)(105606002)(23726002)(2950100001)(46406003)(110136002)(5001960100002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0301MB1225;H:az84smr01.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1225;2:i+ifgenJ7xVi4a7Kmfig8PnQXnKd2sF8SrT2RXOY1BpJnlmXG5j4VOgq+vwPHiPtMPNO4YUFgAHNHCVhLrjYfwAQjAEYbElwPriU2Hv935r9uNo435KgKOm2q5HCasGfVnN+8h8siMUWAkt2ArxGqe54WKnkWxBMIP55J28nf9U=;3:XUU4HR4HZsS/uzIV1Atk2nEVWkgj4wCBM6NoNW8zKXyfswrOzL4kd16rgYzhDq+ZHJxPvkgTjYaXv6fKMYMHcSuoxqLNzkhe5PZrFulD3bShfkuF/evAqpf/tdgZTMycdbXPsn8qj30Sacx4EHMeI39ORtoTm+pV1vYcIc0wOdLyfCqT2IqLlu+Od4DJHPG6cIEFZWb8ACTymwBJHK5vH96YfF8SAyRHGI8GR6D7tpk=;25:FoTyorx/Mh/YWeUaUYR1J9ZaQGHNlgIB+qZmYioZ3Y4kZyWtSlIudVrNudWjV5GSKtN3yuZkoN2cCOnQL+i/nnC25LBZ3ZSvjXW2tYNeCqf7BlEjUfNOz8bple9eIl/+M7v1Zar2XdvlwFKbjw7pJEoAkgco1IlAFPfAjgMueguP6SmN4hNQPpMfrFpCPpiLzs7CSq6vwZ6vkxcaE42hmbJ7m4THXsx+f1HFe33y/TRtgO9s5b1LlrJFi7GntLzCzbuiN7C/40Kc26uraXD4gg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB1225; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1225;20:oCiKtzhhJjwAdL5AwlYpUFxnJ9SGs0FqtTgPggVJlusklkGdPLpn5G6M2+rJOpEr5G9rDBaBjvyG9yrc2E3HuwjENaSIQb44yFlUJjBI8u0i9v5um47diddY36xppbeFQDSZo8CfHAT9LZJwL37ESnbq60jo6dF3qtjUfLQ48hd2UmvftKE1ghQFHArOp3UrqITcqPZxnQtOH8e6Mj0w/aaOEIQ1E+EzAaMLHQvfisw2yvbWAwGORWsf7eeA8mlSlJ6qEAC2WD3JOTHpOCQ13HdIg6C0ffE9b3QW97dObg8KLjvxE6kBfbb7AzQEYxjFrN6jYZmewTQ3634oQVDG2LQaOs4LCw+FUUxseKyo7C4=;4:OVlJVfH8oES36DCe5HdGJB8ygJYG1xDBidMcpHrKczNIZY/xv2We63jClNiovv1VTcAQ8WAKWuoLCruxDktutBEIYTuCbAUgTXYQICGIdBdK/vrOkGeI77vVkxU+MxyxceV9LmFBJRNL3XWjuVzhh9FvaKJmFa9dTLfsQqb4UqbQW5K5CPa6Qr+61NBLBMv9GOCsOhMocYHT6GpmuoxmAvvrVYitOiLPYfeHvITZnpEEIThy76i77lX8q8Ev+XGw2vAlV3ZoMPDkq9oI09xICFarCPSMLFHUIgwztyEKZpfyb1eSa10eWJHmbshFFEAcg7khnD/K0SXX3CPYyzaF6w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:CY1PR0301MB1225;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB1225; X-Forefront-PRVS: 069255B8B8 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR0301MB1225;23:xKC7LWa/WUJv11HgFxPcImPPTFGIqnH2F2lIDjn?= =?us-ascii?Q?MfmHTx+0qEle392JnPNsRLyMjsDYkAN0NoiuhvYvVzgZIJwQeaGl1Vurxk7X?= =?us-ascii?Q?zae94agHHEB/97MNfHHjhCwNDqTprzC/8uD4GhaGIp60UpNF/Yb8gQS4qbEa?= =?us-ascii?Q?Fhidu+29FvzEjfSW7I2hq5KG9poVXf1qFCPmHLzHiVLajMS1JFCYdcsZVGAK?= =?us-ascii?Q?68cmTxWDxp532oEBUnWENNjZDdBy9n3B+tTUcRz1/HMNjA64DIUXDZhCweWW?= =?us-ascii?Q?rL8Uz9kAdwvf7fUvHMtqS19GtGLmiIlhVUFZETWE2lyUeCoh8VLxoPDWaSdO?= =?us-ascii?Q?87asKLmIyMEnljniR/GLkcgXVN12GXen2jnkrqD4URbWcMapFUbKKTsYOdFT?= =?us-ascii?Q?l4TjhX96KtuopNfDHJLR+q1cVXpYrl84VC8mfUxcPe7eEtjrNl1xIRIJUkto?= =?us-ascii?Q?fQ2I/rx/8z23ceuXLzXnAyyCZ4R6p+T6uSTzUrZzPggifKS5xgiempU/MyNL?= =?us-ascii?Q?BoV55lXKsTAVyIT2JM7DxlbYd2Yd6vVMkCWoHWgnWwMECXVE7hrW94s2stYS?= =?us-ascii?Q?2agk0otPOZXmkRhJONSfJHmbyTRIDTo+v2zHqc+q6RcGtU7zT7xr2u3EZVdM?= =?us-ascii?Q?Zl+IIXcW2GrMFkDF3C8MK2qMv3SYCLEbNAbTg2EyNl4AH1l+/TlUSHGa9pqM?= =?us-ascii?Q?IM8EE0ufrMxpxJER4FfUkNcPUBVFQqcPIqPTM8SxhMdXvlggS+2KSXED0/Sa?= =?us-ascii?Q?YcJ+BokLlXlvhaPQug9mjpzFjwaJ1tfF6hsyXHnuYctuxZwYDKxn+47sPDFC?= =?us-ascii?Q?6C7+p/xEQvWuA5C1jFifmY7E/bbcNJAJM/T8Ju4x8jKh388S/1xDuyWeCwo+?= =?us-ascii?Q?ZC1uJfkw5u6JX2l+F7yneJF3oVk3QNQtUO9VEAzBaxzWZzBGO0C19DhcDM6h?= =?us-ascii?Q?7wTGOnDNGG+vBMaS3aLVe7WaKkAIepkO2zkjzR4mLAv7KJlSN2JYeF1izSGB?= =?us-ascii?Q?OaNrN4FgbWXCSCJavmukYJ57Ec7/DrWB1H+7EfUaE3r3lP7YACX9N9yn3Z5b?= =?us-ascii?Q?LTixw+qLFdu7xdyB+vqLX8R4GCIwV1cLMd3qZlq1mIFmFYhCayiwkVGHdg+V?= =?us-ascii?Q?5WrPQPCaNPogu6V8txHM8kBqoIss7jeREFjsCQd4W6+dkKivRxoAZfJQDBPk?= =?us-ascii?Q?jBBng9b87HVhkF+cC1MpfRjI9Hr+MPqp8ppYwRpfMGTdwoQgerGvgVpSn7g?= =?us-ascii?Q?=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1225;5:HsqHkGvXI+Fp/JQQa/agDFTwckjl1fKWfWsDwMGOVBZ+q1QWscGx6yTRaWyVb+w954hEn379dUS94t1ayPCUagcMWqbBcDynOzPMZ7ahF7jSXs4uXRtorcQ+a2pstf+DRXmzDiqekPDLcFQmsLpFxw==;24:ChP/siaDym4mEB3UEd4YkQwbvq+fwCeVFreTTXzAw3fGeaH1a6A6fTykuU6P3Y/0uR/yGus8Ss1safFLpNTQkP89XVuC2kIH2KWSlnIx+oQ=;20:0bJ/koybkVD6V/4PE8rYQ8orOxPsKIwwmKKa5aYfPM90f8d/6JoZ3MModJD05rG2+P9reKAXg1voOEfhtBYf1Q== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2015 02:36:44.4502 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB1225 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 24, 2015 at 04:21:15PM +0300, Roger Quadros wrote: > This is to prevent missing symbol build error if OTG is > enabled (built-in) and HCD core (CONFIG_USB) is module. > > Signed-off-by: Roger Quadros > Acked-by: Peter Chen > --- > drivers/usb/common/usb-otg-fsm.c | 6 ++++-- > drivers/usb/phy/phy-fsl-usb.c | 2 ++ > include/linux/usb/otg-fsm.h | 1 + > 3 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/common/usb-otg-fsm.c b/drivers/usb/common/usb-otg-fsm.c > index a46f29a..6e56c8c 100644 > --- a/drivers/usb/common/usb-otg-fsm.c > +++ b/drivers/usb/common/usb-otg-fsm.c > @@ -165,8 +165,10 @@ static int otg_set_state(struct otg_fsm *fsm, enum usb_otg_state new_state) > otg_loc_conn(fsm, 0); > otg_loc_sof(fsm, 1); > otg_set_protocol(fsm, PROTO_HOST); > - usb_bus_start_enum(fsm->otg->host, > - fsm->otg->host->otg_port); > + if (fsm->ops->start_enum) { > + fsm->ops->start_enum(fsm->otg->host, > + fsm->otg->host->otg_port); > + } > break; > case OTG_STATE_A_IDLE: > otg_drv_vbus(fsm, 0); > diff --git a/drivers/usb/phy/phy-fsl-usb.c b/drivers/usb/phy/phy-fsl-usb.c > index ee3f2c2..19541ed 100644 > --- a/drivers/usb/phy/phy-fsl-usb.c > +++ b/drivers/usb/phy/phy-fsl-usb.c > @@ -783,6 +783,8 @@ static struct otg_fsm_ops fsl_otg_ops = { > > .start_host = fsl_otg_start_host, > .start_gadget = fsl_otg_start_gadget, > + > + .start_enum = usb_bus_start_enum, > }; > > /* Initialize the global variable fsl_otg_dev and request IRQ for OTG */ > diff --git a/include/linux/usb/otg-fsm.h b/include/linux/usb/otg-fsm.h > index 672551c..75e82cc 100644 > --- a/include/linux/usb/otg-fsm.h > +++ b/include/linux/usb/otg-fsm.h > @@ -199,6 +199,7 @@ struct otg_fsm_ops { > void (*del_timer)(struct otg_fsm *fsm, enum otg_fsm_timer timer); > int (*start_host)(struct otg_fsm *fsm, int on); > int (*start_gadget)(struct otg_fsm *fsm, int on); > + int (*start_enum)(struct usb_bus *bus, unsigned port_num); > }; > > Get one build warning: In file included from /u/home/b29397/work/projects/usb/drivers/usb/chipidea/udc.c:23:0: /u/home/b29397/work/projects/usb/include/linux/usb/otg-fsm.h:207:27: warning: 'struct usb_bus' declared inside parameter list int (*start_enum)(struct usb_bus *bus, unsigned port_num); ^ /u/home/b29397/work/projects/usb/include/linux/usb/otg-fsm.h:207:27: warning: its scope is only this definition or declaration, which is probably not what you want It probably dues to we should not have struct usb_bus* at udc driver -- Best Regards, Peter Chen