From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751599AbbIGEKM (ORCPT ); Mon, 7 Sep 2015 00:10:12 -0400 Received: from e28smtp09.in.ibm.com ([122.248.162.9]:35323 "EHLO e28smtp09.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750765AbbIGEKJ (ORCPT ); Mon, 7 Sep 2015 00:10:09 -0400 X-Helo: d28dlp01.in.ibm.com X-MailFrom: srikar@linux.vnet.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Date: Mon, 7 Sep 2015 09:40:01 +0530 From: Srikar Dronamraju To: Wanpeng Li Cc: Ingo Molnar , Peter Zijlstra , linux-kernel@vger.kernel.org, Rik van Riel , Mel Gorman Subject: Re: [PATCH v2 4/4] sched/numa: Convert sched_numa_balancing to a static_branch Message-ID: <20150907041001.GA7066@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <1439290813-6683-1-git-send-email-srikar@linux.vnet.ibm.com> <1439310261-16124-1-git-send-email-srikar@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15090704-0033-0000-0000-000007A87FCB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Wanpeng Li [2015-09-06 12:01:10]: Hi Wanpeng Li, > Hi Srikar, > On 8/12/15 12:24 AM, Srikar Dronamraju wrote: > >Variable sched_numa_balancing toggles numa_balancing feature. Hence > >moving from a simple read mostly variable to a more apt static_branch. > > > >Suggested-by: Peter Zijlstra > >Signed-off-by: Srikar Dronamraju > > > This commit breaks Peter's queue: > > kernel/sched/fair.c: In function ?task_numa_fault?: > kernel/sched/fair.c:2072: error: implicit declaration of function > ?static_branch_likely? > kernel/sched/fair.c: In function ?task_tick_fair?: > kernel/sched/fair.c:7867: error: implicit declaration of function > ?static_branch_unlikely? > make[1]: *** [kernel/sched/fair.o] Error 1 > make[1]: *** Waiting for unfinished jobs.... > kernel/sched/core.c:2116: warning: data definition has no type or storage > class Thanks for reporting. Can you please confirm if you have the commit http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=11276d5306b8e5b438a36bbff855fe792d7eaa61 >>From 11276d5306b8e5b438a36bbff855fe792d7eaa61 Mon Sep 17 00:00:00 2001 From: Peter Zijlstra Date: Fri, 24 Jul 2015 15:09:55 +0200 Subject: [PATCH] locking/static_keys: Add a new static_key interface -- Thanks and Regards Srikar Dronamraju