From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752958AbbIGGqU (ORCPT ); Mon, 7 Sep 2015 02:46:20 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59664 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751106AbbIGGqR (ORCPT ); Mon, 7 Sep 2015 02:46:17 -0400 Date: Sun, 6 Sep 2015 23:46:16 -0700 From: Greg KH To: Enric Balletbo Serra Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Sjoerd Simons , Javier Martinez Canillas , span@analogixsemi.com, nathan.chung@mediatek.com Subject: Re: [PATCH 3/3] staging: slimport: Add anx7814 driver support by analogix. Message-ID: <20150907064616.GA30173@kroah.com> References: <1441574042-18091-1-git-send-email-enric.balletbo@collabora.com> <1441574042-18091-4-git-send-email-enric.balletbo@collabora.com> <20150906232728.GA26448@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 07, 2015 at 07:41:08AM +0200, Enric Balletbo Serra wrote: > 2015-09-07 1:27 GMT+02:00 Greg KH : > > On Sun, Sep 06, 2015 at 11:14:02PM +0200, Enric Balletbo i Serra wrote: > >> The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter > >> designed for portable devices. > >> > >> This driver adds initial support and supports HDMI to DP pass-through mode. > >> > >> Signed-off-by: Enric Balletbo i Serra > >> --- > >> drivers/staging/Kconfig | 2 + > >> drivers/staging/Makefile | 1 + > >> drivers/staging/slimport/Kconfig | 7 + > >> drivers/staging/slimport/Makefile | 4 + > >> drivers/staging/slimport/slimport.c | 301 +++ > >> drivers/staging/slimport/slimport.h | 49 + > >> drivers/staging/slimport/slimport_tx_drv.c | 3293 ++++++++++++++++++++++++++++ > >> drivers/staging/slimport/slimport_tx_drv.h | 254 +++ > >> drivers/staging/slimport/slimport_tx_reg.h | 786 +++++++ > > > > Why is this a staging driver? > > What prevents it from being merged into the "real" part of the kernel > > tree? > > > > I'll be glad to move the driver to their subsystem if you think it's a > the better place. Basically there are two reasons why I send the > driver to the staging directory. The first one is because my test > environment is a bit limited, with my environment I can only test the > HDMI to DisplayPort pass-through mode so the driver builds but it's > partially tested. The second one is that I expect I'll need to > refactor some code, specially in slimport_tx_drv.c file to be > accepted, I decided not change too much this file from the original to > not break the functionality, so I thought that will be better send > first to the staging driver to have first reviews. > > > All staging drivers need a TODO file, listing what needs to be done and > > who is in charge of it. I can't take this without that added. > > > > ok, I'll add in the next series once received some feedback (or move > to the video subsystem) I suggest trying to get it merged "properly" first before having to fall-back to the staging subsystem. thanks, greg k-h