From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753281AbbIGHh4 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 7 Sep 2015 03:37:56 -0400
Received: from mail-wi0-f180.google.com ([209.85.212.180]:33992 "EHLO
	mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751224AbbIGHhy (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 7 Sep 2015 03:37:54 -0400
Date: Mon, 7 Sep 2015 09:37:50 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Mikko Rapeli <mikko.rapeli@iki.fi>
Cc: linux-kernel@vger.kernel.org, Andy Lutomirski <luto@amacapital.net>,
        Andrew Morton <akpm@linux-foundation.org>,
        Denys Vlasenko <dvlasenk@redhat.com>, Brian Gerst <brgerst@gmail.com>,
        Peter Zijlstra <peterz@infradead.org>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Oleg Nesterov <oleg@redhat.com>, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 15/15] x86/headers: Remove <asm/sigcontext.h>
Message-ID: <20150907073750.GB19280@gmail.com>
References: <1441438363-9999-1-git-send-email-mingo@kernel.org>
 <1441438363-9999-16-git-send-email-mingo@kernel.org>
 <20150905105753.GC9187@lakka.kapsi.fi>
 <20150905115943.GA15548@gmail.com>
 <20150905121108.GD9187@lakka.kapsi.fi>
 <20150906064145.GA2364@gmail.com>
 <20150906202815.GE9187@lakka.kapsi.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150906202815.GE9187@lakka.kapsi.fi>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Mikko Rapeli <mikko.rapeli@iki.fi> wrote:

> > > +++ b/arch/x86/include/uapi/asm/sigcontext32.h
> > > @@ -3,6 +3,6 @@
> > >  
> > >  /* This is a legacy file - all the type definitions are in sigcontext.h: */
> > >  
> > > -#include <uapi/asm/sigcontext.h>
> > > +#include <asm/sigcontext.h>
> > 
> > There's no asm/sigcontext.h file anymore if you apply my patches - but we could 
> > reintroduce it to make the copy of UAPI headers to user-space work as-is.
> 
> Actually there is, in user space :)

I mean in the kernel arch/x86/include/asm/sigcontext.h is gone (at least in that 
series), we use the UAPI header directly.

> Then a nice solution would be for the kernel side wrapper to do like you
> said (on top of your changes on master):
> 
> --- /dev/null
> +++ b/arch/x86/include/asm/sigcontext.h
> @@ -0,0 +1,6 @@
> +#ifndef _ASM_X86_SIGCONTEXT_H
> +#define _ASM_X86_SIGCONTEXT_H
> +
> +#include <uapi/asm/sigcontext.h>
> +
> +#endif /* _ASM_X86_SIGCONTEXT_H */
> 
> And I guess logically this belongs to commit "x86/headers: Remove
> <asm/sigcontext.h>".

Yeah, will do this, plus some comments explaining that this is really just so that 
we can keep the UAPI side compatible with a 'straight user-space copying of the 
header files'.

This won't affect the kernel as we won't include asm/sigcontext.h directly. (And 
even if we do, there's no harm done.)

Agreed?

Thanks,

	Ingo