From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754083AbbIGJ3p (ORCPT ); Mon, 7 Sep 2015 05:29:45 -0400 Received: from ozlabs.org ([103.22.144.67]:38567 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753093AbbIGJ3n (ORCPT ); Mon, 7 Sep 2015 05:29:43 -0400 In-Reply-To: <1440415228-8006-4-git-send-email-haokexin@gmail.com> To: Kevin Hao From: Michael Ellerman Cc: Peter Zijlstra , linuxppc-dev@lists.ozlabs.org, Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [v2,3/6] powerpc: kill mfvtb() Message-Id: <20150907092942.1EF38140281@ozlabs.org> Date: Mon, 7 Sep 2015 19:29:42 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-24-08 at 11:20:25 UTC, Kevin Hao wrote: > This function is only used by get_vtb(). They are almost the same > except the reading from the real register. Move the mfspr() to > get_vtb() and kill the function mfvtb(). With this, we can eliminate > the use of cpu_has_feature() in very core header file like reg.h. > This is a preparation for the use of jump label for cpu_has_feature(). I don't mind this change. But can you elaborate a bit on the issue with using cpu_has_feature() in reg.h? Just so I can understand the problem. I assume you ended up in a big mess of includes when you tried to include jump_label.h from reg.h? cheers