From: Christian Gromm <christian.gromm@microchip.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: most: MOST and MOSTCORE should depend on HAS_DMA
Date: Mon, 7 Sep 2015 11:00:57 +0200 [thread overview]
Message-ID: <20150907110057.1c3b0189@muaddib> (raw)
In-Reply-To: <1441137958-27936-1-git-send-email-geert@linux-m68k.org>
On Tue, 1 Sep 2015 22:05:58 +0200
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> If NO_DMA=y:
>
> ERROR: "dma_free_coherent" [drivers/staging/most/mostcore/mostcore.ko] undefined!
> ERROR: "dma_alloc_coherent" [drivers/staging/most/mostcore/mostcore.ko] undefined!
>
> As all MOST sub drivers use DMA functionality, add a dependency on
> HAS_DMA to MOSTCORE, and to MOST, which selects MOSTCORE.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Christian Gromm <christian.gromm@microchip.com>
> ---
> drivers/staging/most/Kconfig | 1 +
> drivers/staging/most/mostcore/Kconfig | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/staging/most/Kconfig b/drivers/staging/most/Kconfig
> index d50de03de7b98972..0b9b9b539f70562d 100644
> --- a/drivers/staging/most/Kconfig
> +++ b/drivers/staging/most/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig MOST
> tristate "MOST driver"
> + depends on HAS_DMA
> select MOSTCORE
> default n
> ---help---
> diff --git a/drivers/staging/most/mostcore/Kconfig b/drivers/staging/most/mostcore/Kconfig
> index 38abf1b21b6623c7..47172546d7280ee6 100644
> --- a/drivers/staging/most/mostcore/Kconfig
> +++ b/drivers/staging/most/mostcore/Kconfig
> @@ -4,6 +4,7 @@
>
> config MOSTCORE
> tristate "MOST Core"
> + depends on HAS_DMA
>
> ---help---
> Say Y here if you want to enable MOST support.
prev parent reply other threads:[~2015-09-07 9:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 20:05 [PATCH] Staging: most: MOST and MOSTCORE should depend on HAS_DMA Geert Uytterhoeven
2015-09-07 9:00 ` Christian Gromm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150907110057.1c3b0189@muaddib \
--to=christian.gromm@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).