* [PATCH] Staging: most: MOST and MOSTCORE should depend on HAS_DMA
@ 2015-09-01 20:05 Geert Uytterhoeven
2015-09-07 9:00 ` Christian Gromm
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2015-09-01 20:05 UTC (permalink / raw)
To: Greg Kroah-Hartman, Christian Gromm
Cc: devel, linux-kernel, Geert Uytterhoeven
If NO_DMA=y:
ERROR: "dma_free_coherent" [drivers/staging/most/mostcore/mostcore.ko] undefined!
ERROR: "dma_alloc_coherent" [drivers/staging/most/mostcore/mostcore.ko] undefined!
As all MOST sub drivers use DMA functionality, add a dependency on
HAS_DMA to MOSTCORE, and to MOST, which selects MOSTCORE.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/staging/most/Kconfig | 1 +
drivers/staging/most/mostcore/Kconfig | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/staging/most/Kconfig b/drivers/staging/most/Kconfig
index d50de03de7b98972..0b9b9b539f70562d 100644
--- a/drivers/staging/most/Kconfig
+++ b/drivers/staging/most/Kconfig
@@ -1,5 +1,6 @@
menuconfig MOST
tristate "MOST driver"
+ depends on HAS_DMA
select MOSTCORE
default n
---help---
diff --git a/drivers/staging/most/mostcore/Kconfig b/drivers/staging/most/mostcore/Kconfig
index 38abf1b21b6623c7..47172546d7280ee6 100644
--- a/drivers/staging/most/mostcore/Kconfig
+++ b/drivers/staging/most/mostcore/Kconfig
@@ -4,6 +4,7 @@
config MOSTCORE
tristate "MOST Core"
+ depends on HAS_DMA
---help---
Say Y here if you want to enable MOST support.
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: most: MOST and MOSTCORE should depend on HAS_DMA
2015-09-01 20:05 [PATCH] Staging: most: MOST and MOSTCORE should depend on HAS_DMA Geert Uytterhoeven
@ 2015-09-07 9:00 ` Christian Gromm
0 siblings, 0 replies; 2+ messages in thread
From: Christian Gromm @ 2015-09-07 9:00 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Greg Kroah-Hartman, devel, linux-kernel
On Tue, 1 Sep 2015 22:05:58 +0200
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> If NO_DMA=y:
>
> ERROR: "dma_free_coherent" [drivers/staging/most/mostcore/mostcore.ko] undefined!
> ERROR: "dma_alloc_coherent" [drivers/staging/most/mostcore/mostcore.ko] undefined!
>
> As all MOST sub drivers use DMA functionality, add a dependency on
> HAS_DMA to MOSTCORE, and to MOST, which selects MOSTCORE.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Christian Gromm <christian.gromm@microchip.com>
> ---
> drivers/staging/most/Kconfig | 1 +
> drivers/staging/most/mostcore/Kconfig | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/staging/most/Kconfig b/drivers/staging/most/Kconfig
> index d50de03de7b98972..0b9b9b539f70562d 100644
> --- a/drivers/staging/most/Kconfig
> +++ b/drivers/staging/most/Kconfig
> @@ -1,5 +1,6 @@
> menuconfig MOST
> tristate "MOST driver"
> + depends on HAS_DMA
> select MOSTCORE
> default n
> ---help---
> diff --git a/drivers/staging/most/mostcore/Kconfig b/drivers/staging/most/mostcore/Kconfig
> index 38abf1b21b6623c7..47172546d7280ee6 100644
> --- a/drivers/staging/most/mostcore/Kconfig
> +++ b/drivers/staging/most/mostcore/Kconfig
> @@ -4,6 +4,7 @@
>
> config MOSTCORE
> tristate "MOST Core"
> + depends on HAS_DMA
>
> ---help---
> Say Y here if you want to enable MOST support.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-07 9:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-01 20:05 [PATCH] Staging: most: MOST and MOSTCORE should depend on HAS_DMA Geert Uytterhoeven
2015-09-07 9:00 ` Christian Gromm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).