From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754085AbbIGJAj (ORCPT <rfc822;w@1wt.eu>);
	Mon, 7 Sep 2015 05:00:39 -0400
Received: from exsmtp03.microchip.com ([198.175.253.49]:61168 "EHLO
	email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1753534AbbIGJAg (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 7 Sep 2015 05:00:36 -0400
Date: Mon, 7 Sep 2015 11:00:57 +0200
From: Christian Gromm <christian.gromm@microchip.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: most: MOST and MOSTCORE should depend on
 HAS_DMA
Message-ID: <20150907110057.1c3b0189@muaddib>
In-Reply-To: <1441137958-27936-1-git-send-email-geert@linux-m68k.org>
References: <1441137958-27936-1-git-send-email-geert@linux-m68k.org>
Organization: MCHP
X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 1 Sep 2015 22:05:58 +0200
Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> If NO_DMA=y:
> 
>     ERROR: "dma_free_coherent" [drivers/staging/most/mostcore/mostcore.ko] undefined!
>     ERROR: "dma_alloc_coherent" [drivers/staging/most/mostcore/mostcore.ko] undefined!
> 
> As all MOST sub drivers use DMA functionality, add a dependency on
> HAS_DMA to MOSTCORE, and to MOST, which selects MOSTCORE.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Christian Gromm <christian.gromm@microchip.com>
> ---
>  drivers/staging/most/Kconfig          | 1 +
>  drivers/staging/most/mostcore/Kconfig | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/most/Kconfig b/drivers/staging/most/Kconfig
> index d50de03de7b98972..0b9b9b539f70562d 100644
> --- a/drivers/staging/most/Kconfig
> +++ b/drivers/staging/most/Kconfig
> @@ -1,5 +1,6 @@
>  menuconfig MOST
>          tristate "MOST driver"
> +	depends on HAS_DMA
>          select MOSTCORE
>          default n
>          ---help---
> diff --git a/drivers/staging/most/mostcore/Kconfig b/drivers/staging/most/mostcore/Kconfig
> index 38abf1b21b6623c7..47172546d7280ee6 100644
> --- a/drivers/staging/most/mostcore/Kconfig
> +++ b/drivers/staging/most/mostcore/Kconfig
> @@ -4,6 +4,7 @@
>  
>  config MOSTCORE
>  	tristate "MOST Core"
> +	depends on HAS_DMA
>  
>  	---help---
>  	  Say Y here if you want to enable MOST support.