From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing
Date: Mon, 7 Sep 2015 13:43:14 +0200 [thread overview]
Message-ID: <20150907114314.GD5806@krava.brq.redhat.com> (raw)
In-Reply-To: <1441406717-1717-3-git-send-email-andi@firstfloor.org>
On Fri, Sep 04, 2015 at 03:45:13PM -0700, Andi Kleen wrote:
SNIP
> @@ -695,11 +743,7 @@ static void print_counter_aggr(struct perf_evsel *counter, char *prefix)
> }
>
> uval = avg * counter->scale;
> -
> - if (nsec_counter(counter))
> - nsec_printout(-1, 0, counter, uval);
> - else
> - abs_printout(-1, 0, counter, uval);
> + printout(-1, 0, counter, uval);
>
> print_noise(counter, avg);
>
> @@ -752,15 +796,9 @@ static void print_counter(struct perf_evsel *counter, char *prefix)
> }
>
> uval = val * counter->scale;
> -
> - if (nsec_counter(counter))
> - nsec_printout(cpu, 0, counter, uval);
> - else
> - abs_printout(cpu, 0, counter, uval);
> -
> + printout(cpu, 0, counter, uval);
> if (!csv_output)
> print_noise(counter, 1.0);
> - print_running(run, ena);
why is this one removed?
jirka
next prev parent reply other threads:[~2015-09-07 11:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 22:45 perf, tools: Refactor and support interval and CSV metrics v4 Andi Kleen
2015-09-04 22:45 ` [PATCH 1/6] perf, tools, stat: Move sw clock metrics printout to stat-shadow Andi Kleen
2015-09-04 22:50 ` Arnaldo Carvalho de Melo
2015-09-04 22:45 ` [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing Andi Kleen
2015-09-07 11:43 ` Jiri Olsa [this message]
2015-09-07 12:14 ` Jiri Olsa
2015-09-08 16:03 ` Andi Kleen
2015-09-08 16:20 ` Jiri Olsa
2015-09-04 22:45 ` [PATCH 3/6] perf, tools, stat: Add support for metrics in interval mode Andi Kleen
2015-09-04 22:45 ` [PATCH 4/6] perf, tools, stat: Move noise/running printing into printout Andi Kleen
2015-09-04 22:45 ` [PATCH 5/6] perf, tools, stat: Implement CSV metrics output Andi Kleen
2015-09-04 22:45 ` [PATCH 6/6] perf, tools, stat: Move non counting counter printing to printout Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150907114314.GD5806@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox