From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752850AbbIGMjp (ORCPT ); Mon, 7 Sep 2015 08:39:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60198 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751489AbbIGMjm (ORCPT ); Mon, 7 Sep 2015 08:39:42 -0400 Date: Mon, 7 Sep 2015 14:36:57 +0200 From: Oleg Nesterov To: Chen Gang Cc: Andrew Morton , "kirill.shutemov@linux.intel.com" , "riel@redhat.com" , Michal Hocko , "sasha.levin@oracle.com" , "pfeiner@google.com" , "aarcange@redhat.com" , "vishnu.ps@samsung.com" , Linux Memory , kernel mailing list Subject: Re: [PATCH] mm/mmap.c: Remove useless statement "vma = NULL" in find_vma() Message-ID: <20150907123656.GA32668@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/05, Chen Gang wrote: > > From b12fa5a9263cf4c044988e59f0071f4bcc132215 Mon Sep 17 00:00:00 2001 > From: Chen Gang > Date: Sat, 5 Sep 2015 21:49:56 +0800 > Subject: [PATCH] mm/mmap.c: Remove useless statement "vma = NULL" in >  find_vma() > > Before the main looping, vma is already is NULL, so need not set it to > NULL, again. > > Signed-off-by: Chen Gang Reviewed-by: Oleg Nesterov > --- >  mm/mmap.c | 1 - >  1 file changed, 1 deletion(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index df6d5f0..4db7cf0 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -2054,7 +2054,6 @@ struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr) >   return vma; >   >   rb_node = mm->mm_rb.rb_node; > - vma = NULL; >   >   while (rb_node) { >   struct vm_area_struct *tmp; > --  > 1.9.3 > >