From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752032AbbIGMzi (ORCPT ); Mon, 7 Sep 2015 08:55:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48584 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751450AbbIGMzg (ORCPT ); Mon, 7 Sep 2015 08:55:36 -0400 Date: Mon, 7 Sep 2015 14:52:47 +0200 From: Oleg Nesterov To: Daniel Wagner , "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com, bobby.prani@gmail.com Subject: Re: [PATCH RFC tip/core/rcu 3/9] rcu_sync: Add CONFIG_PROVE_RCU checks Message-ID: <20150907125247.GA862@redhat.com> References: <20150829032643.GA19166@linux.vnet.ibm.com> <1440819361-20251-1-git-send-email-paulmck@linux.vnet.ibm.com> <1440819361-20251-3-git-send-email-paulmck@linux.vnet.ibm.com> <55ED5294.1040009@monom.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55ED5294.1040009@monom.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/07, Daniel Wagner wrote: > > On 08/29/2015 05:35 AM, Paul E. McKenney wrote: > > +extern bool __rcu_sync_is_idle(struct rcu_sync *); > > + > > /** > > * rcu_sync_is_idle() - Are readers permitted to use their fastpaths? > > * @rsp: Pointer to rcu_sync structure to use for synchronization > > @@ -50,7 +52,11 @@ struct rcu_sync { > > */ > > static inline bool rcu_sync_is_idle(struct rcu_sync *rsp) > > { > > +#ifdef CONFIG_PROVE_RCU > > + return __rcu_sync_is_idle(rss); > > s/rss/rsp? Hmm, yes. Paul, it seems that you renamed "rss" to "rsp" globally (I didn't even notice this change), but forgot about this one ;) Should I send the patch or will you fix this yourself? Oleg.