From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752135AbbIGX6k (ORCPT <rfc822;w@1wt.eu>);
	Mon, 7 Sep 2015 19:58:40 -0400
Received: from mail-pa0-f51.google.com ([209.85.220.51]:35233 "EHLO
	mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751180AbbIGX6j (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 7 Sep 2015 19:58:39 -0400
Date: Tue, 8 Sep 2015 08:59:22 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Luis Henriques <luis.henriques@canonical.com>
Cc: Minchan Kim <minchan@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH v2] zram: fix possible use after free in zcomp_create()
Message-ID: <20150907235922.GB6896@swordfish>
References: <20150907133332.GA539@swordfish>
 <1441635190-13991-1-git-send-email-luis.henriques@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1441635190-13991-1-git-send-email-luis.henriques@canonical.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (09/07/15 15:13), Luis Henriques wrote:
> zcomp_create() verifies the success of zcomp_strm_{multi,siggle}_create()
> through comp->stream, which can potentially be pointing to memory that was
> freed if these functions returned an error.
> 
> Fixes: beca3ec71fe5 ("zram: add multi stream functionality")
> Cc: stable@vger.kernel.org
> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>

Cc Andrew


Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

	-ss

> ---
> Changes since v1:
>  * Check zcomp_strm_{multi,siggle}_create() return code instead
>    comp->stream (suggested by Sergey)
> 
> drivers/block/zram/zcomp.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/block/zram/zcomp.c b/drivers/block/zram/zcomp.c
> index 965d1afb0eaa..8d2cdfd307db 100644
> --- a/drivers/block/zram/zcomp.c
> +++ b/drivers/block/zram/zcomp.c
> @@ -336,6 +336,7 @@ struct zcomp *zcomp_create(const char *compress, int max_strm)
>  {
>  	struct zcomp *comp;
>  	struct zcomp_backend *backend;
> +	int ret;
>  
>  	backend = find_backend(compress);
>  	if (!backend)
> @@ -347,10 +348,10 @@ struct zcomp *zcomp_create(const char *compress, int max_strm)
>  
>  	comp->backend = backend;
>  	if (max_strm > 1)
> -		zcomp_strm_multi_create(comp, max_strm);
> +		ret = zcomp_strm_multi_create(comp, max_strm);
>  	else
> -		zcomp_strm_single_create(comp);
> -	if (!comp->stream) {
> +		ret = zcomp_strm_single_create(comp);
> +	if (ret) {
>  		kfree(comp);
>  		return ERR_PTR(-ENOMEM);
>  	}
>