From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752346AbbIHBT7 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 7 Sep 2015 21:19:59 -0400
Received: from mail-pa0-f54.google.com ([209.85.220.54]:36515 "EHLO
	mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751222AbbIHBT4 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 7 Sep 2015 21:19:56 -0400
Date: Tue, 8 Sep 2015 10:20:38 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Luis Henriques <luis.henriques@canonical.com>,
        Nitin Gupta <ngupta@vflare.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] zram: fix possible use after free in zcomp_create()
Message-ID: <20150908012038.GE6896@swordfish>
References: <20150907133332.GA539@swordfish>
 <1441635190-13991-1-git-send-email-luis.henriques@canonical.com>
 <20150908010718.GA19776@bbox>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150908010718.GA19776@bbox>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (09/08/15 10:07), Minchan Kim wrote:
[..]
> > +	int ret;
> 
> For the clarification, I want to call it as 'error' instead of ret.
> 
> >  
> >  	backend = find_backend(compress);
> >  	if (!backend)
> > @@ -347,10 +348,10 @@ struct zcomp *zcomp_create(const char *compress, int max_strm)
> >  
> >  	comp->backend = backend;
> >  	if (max_strm > 1)
> > -		zcomp_strm_multi_create(comp, max_strm);
> > +		ret = zcomp_strm_multi_create(comp, max_strm);
> >  	else
> > -		zcomp_strm_single_create(comp);
> > -	if (!comp->stream) {
> > +		ret = zcomp_strm_single_create(comp);
> > +	if (ret) {
> >  		kfree(comp);
> >  		return ERR_PTR(-ENOMEM);
> >  	}
> 
> And we could return ERR_PTR(error) rather than fixed -ENOMEM to propagate

yep, I thought about that; looks to be minor so I didn't insist
on changing that. don't mind to change it to ERR_PTR(error).

> other errors potentially could be happen in future(ex, crypto support).
> Of course, we should change description of the function about error return.

on the other hand, this is zcomp_strm_FOO_create(), which is mostly
about memory allocation. but yeah, who knows. We can change this as
a part of crypto api rework; ERR_PTR(error) does not fix anything
per se, so may be we can avoid pushing this change into stable.

	-ss