From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752875AbbIHCLK (ORCPT ); Mon, 7 Sep 2015 22:11:10 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:34894 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751942AbbIHCLF (ORCPT ); Mon, 7 Sep 2015 22:11:05 -0400 Date: Tue, 8 Sep 2015 07:41:01 +0530 From: Viresh Kumar To: "Rafael J. Wysocki" Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, preeti.lkml@gmail.com, open list Subject: Re: [PATCH V2 6/9] cpufreq: ondemand: queue work for policy->cpus together Message-ID: <20150908021101.GA26760@linux> References: <2662457.Ri7bTTTVA1@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2662457.Ri7bTTTVA1@vostro.rjw.lan> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08-09-15, 03:33, Rafael J. Wysocki wrote: > > + /* Make sure the work is not canceled on policy->cpus */ > > I'm not sure what scenario can lead to that. Care to explain? CPUFREQ_GOV_STOP event called for the policy and so all its works are in canceled state. > > + if (!dbs_info->cdbs.shared->policy) > > continue; > > > > next_sampling = jiffies + usecs_to_jiffies(new_rate); > > appointed_at = dbs_info->cdbs.dwork.timer.expires; > > For that to work we always need to do stuff for policy->cpus in sync. > Do we? Hmm, we are not in 100% sync for sure. Will check that again. -- viresh