From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751968AbbIHFEE (ORCPT ); Tue, 8 Sep 2015 01:04:04 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:36801 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751094AbbIHFEB (ORCPT ); Tue, 8 Sep 2015 01:04:01 -0400 Date: Tue, 8 Sep 2015 14:04:42 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Luis Henriques , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH] zram: don't copy invalid compression algorithms Message-ID: <20150908050442.GA609@swordfish> References: <1441658910-10226-1-git-send-email-luis.henriques@canonical.com> <20150907235635.GA6896@swordfish> <20150908011443.GB19776@bbox> <20150908013338.GF6896@swordfish> <20150908015831.GG6896@swordfish> <20150908045017.GA30100@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150908045017.GA30100@bbox> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (09/08/15 13:50), Minchan Kim wrote: [..] > And it's straightforward/consistent to change the thing's state > only if is successful. > what for? I provided several good reasons not to do this, because it makes life easier for users. we added this check in Jun 25, 2015 while this functionality and scripts have been around for years, and apparently now it's users' problem and they must go and do something. seriously, what improvement this change brings in the first place? what does it make better and for whom? -ss