From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752137AbbIHFPN (ORCPT <rfc822;w@1wt.eu>);
	Tue, 8 Sep 2015 01:15:13 -0400
Received: from mail-pa0-f52.google.com ([209.85.220.52]:36244 "EHLO
	mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751344AbbIHFPL (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 8 Sep 2015 01:15:11 -0400
Date: Tue, 8 Sep 2015 14:15:52 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Luis Henriques <luis.henriques@canonical.com>,
        linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH] zram: don't copy invalid compression algorithms
Message-ID: <20150908051552.GB609@swordfish>
References: <1441658910-10226-1-git-send-email-luis.henriques@canonical.com>
 <20150907235635.GA6896@swordfish>
 <20150908011443.GB19776@bbox>
 <20150908013338.GF6896@swordfish>
 <20150908015831.GG6896@swordfish>
 <20150908045017.GA30100@bbox>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150908045017.GA30100@bbox>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (09/08/15 13:50), Minchan Kim wrote:
> For exmaple, disksize, max_comp_streams are changed only if
> it is successful.
> If your logic were right approach, we should change
> max_comp_streams for *stupid* script although it doesn't check

define stupid.

is   echo 2100000 > /sys/block/zram0/max_comp_streams   clever or stupid?

do we control mem_limit_store()? no.
do we contol mem_used_max_store()? no.

if user asks to redefine a "default" value we just let him
do so.

	-ss