From: Peter Zijlstra <peterz@infradead.org>
To: Byungchul Park <byungchul.park@lge.com>
Cc: Wanpeng Li <wanpeng.li@hotmail.com>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, yuyang.du@intel.com
Subject: Re: [PATCH] sched: fix lose fair sleeper bonus in switch_to_fair()
Date: Tue, 8 Sep 2015 13:22:44 +0200 [thread overview]
Message-ID: <20150908112244.GE3644@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20150908091749.GL6455@byungchulpark-X58A-UD3R>
On Tue, Sep 08, 2015 at 06:17:49PM +0900, Byungchul Park wrote:
> even in this case, as i already said, place_entity() should be performed
> after restoring a normalized value to the meaningful original value.
> IMHO, it is wrong that se->vruntime is assigned with a bonused value
> unconditionally. when the task was detached, place_entity() made the
> entity have a bonused vruntime if it was eligible. if it was not
> eligible e.g. it had a too big vruntime before going to sleep, then
> we should not assign a bonused vruntime which is originally intended by
> place_entity().
Correct.
next prev parent reply other threads:[~2015-09-08 11:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 9:45 [PATCH] sched: fix lose fair sleeper bonus in switch_to_fair() Wanpeng Li
2015-09-07 14:02 ` Peter Zijlstra
2015-09-08 3:46 ` Wanpeng Li
2015-09-08 5:28 ` Byungchul Park
2015-09-08 5:38 ` Wanpeng Li
2015-09-08 6:14 ` Byungchul Park
2015-09-08 6:23 ` Wanpeng Li
2015-09-08 6:45 ` Byungchul Park
2015-09-08 6:32 ` Byungchul Park
2015-09-08 6:42 ` Wanpeng Li
2015-09-08 7:11 ` Byungchul Park
2015-09-08 7:30 ` Wanpeng Li
2015-09-08 7:57 ` Byungchul Park
2015-09-08 8:04 ` Wanpeng Li
2015-09-08 8:22 ` Byungchul Park
2015-09-08 8:38 ` Wanpeng Li
2015-09-08 8:45 ` Wanpeng Li
2015-09-08 8:55 ` byungchul.park
2015-09-08 9:17 ` Byungchul Park
2015-09-08 11:22 ` Peter Zijlstra [this message]
2015-09-08 8:48 ` byungchul.park
2015-09-08 6:43 ` Byungchul Park
[not found] ` <BLU437-SMTP75CDA80FC247CB1C9E5A2480540@phx.gbl>
2015-09-08 9:49 ` Peter Zijlstra
2015-09-08 2:10 ` Byungchul Park
2015-09-08 6:55 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150908112244.GE3644@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=byungchul.park@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=wanpeng.li@hotmail.com \
--cc=yuyang.du@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox