From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754614AbbIHLWz (ORCPT ); Tue, 8 Sep 2015 07:22:55 -0400 Received: from casper.infradead.org ([85.118.1.10]:53452 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754252AbbIHLWv (ORCPT ); Tue, 8 Sep 2015 07:22:51 -0400 Date: Tue, 8 Sep 2015 13:22:44 +0200 From: Peter Zijlstra To: Byungchul Park Cc: Wanpeng Li , Ingo Molnar , linux-kernel@vger.kernel.org, yuyang.du@intel.com Subject: Re: [PATCH] sched: fix lose fair sleeper bonus in switch_to_fair() Message-ID: <20150908112244.GE3644@twins.programming.kicks-ass.net> References: <20150908063240.GF6455@byungchulpark-X58A-UD3R> <20150908071139.GI6455@byungchulpark-X58A-UD3R> <20150908075728.GJ6455@byungchulpark-X58A-UD3R> <20150908082239.GK6455@byungchulpark-X58A-UD3R> <20150908091749.GL6455@byungchulpark-X58A-UD3R> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150908091749.GL6455@byungchulpark-X58A-UD3R> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 08, 2015 at 06:17:49PM +0900, Byungchul Park wrote: > even in this case, as i already said, place_entity() should be performed > after restoring a normalized value to the meaningful original value. > IMHO, it is wrong that se->vruntime is assigned with a bonused value > unconditionally. when the task was detached, place_entity() made the > entity have a bonused vruntime if it was eligible. if it was not > eligible e.g. it had a too big vruntime before going to sleep, then > we should not assign a bonused vruntime which is originally intended by > place_entity(). Correct.