From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754558AbbIHLcB (ORCPT ); Tue, 8 Sep 2015 07:32:01 -0400 Received: from foss.arm.com ([217.140.101.70]:54054 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754142AbbIHLb6 (ORCPT ); Tue, 8 Sep 2015 07:31:58 -0400 Date: Tue, 8 Sep 2015 12:31:13 +0100 From: Mark Rutland To: Mark Salter Cc: Catalin Marinas , Will Deacon , "x86@kernel.org" , Andrew Morton , Arnd Bergmann , Ard Biesheuvel , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mm@kvack.org" , "linux-arch@vger.kernel.org" Subject: Re: [PATCH V4 2/3] arm64: support initrd outside kernel linear map Message-ID: <20150908113113.GA20562@leverpostej> References: <1439830867-14935-1-git-send-email-msalter@redhat.com> <1439830867-14935-3-git-send-email-msalter@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439830867-14935-3-git-send-email-msalter@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On Mon, Aug 17, 2015 at 06:01:06PM +0100, Mark Salter wrote: > The use of mem= could leave part or all of the initrd outside of > the kernel linear map. This will lead to an error when unpacking > the initrd and a probable failure to boot. This patch catches that > situation and relocates the initrd to be fully within the linear > map. With next-20150908, this patch results in a confusing message at boot when not using an initrd: Moving initrd from [4080000000-407fffffff] to [9fff49000-9fff48fff] I think that can be solved by folding in the diff below. Thanks, Mark. diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c index 6bab21f..2322479 100644 --- a/arch/arm64/kernel/setup.c +++ b/arch/arm64/kernel/setup.c @@ -364,6 +364,8 @@ static void __init relocate_initrd(void) to_free = ram_end - orig_start; size = orig_end - orig_start; + if (!size) + return; /* initrd needs to be relocated completely inside linear mapping */ new_start = memblock_find_in_range(0, PFN_PHYS(max_pfn),