From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755073AbbIHOV7 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 8 Sep 2015 10:21:59 -0400
Received: from mail-pa0-f50.google.com ([209.85.220.50]:35312 "EHLO
	mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755010AbbIHOVy (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 8 Sep 2015 10:21:54 -0400
Date: Tue, 8 Sep 2015 23:21:43 +0900
From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Luis Henriques <luis.henriques@canonical.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] zram: don't copy invalid compression algorithms
Message-ID: <20150908142143.GA29714@blaptop>
References: <20150907235635.GA6896@swordfish>
 <20150908011443.GB19776@bbox>
 <20150908013338.GF6896@swordfish>
 <20150908015831.GG6896@swordfish>
 <20150908045017.GA30100@bbox>
 <20150908050442.GA609@swordfish>
 <20150908081610.GA8633@bbox>
 <20150908095428.GA14220@swordfish>
 <20150908133303.GA2174@bbox>
 <20150908134401.GA590@swordfish>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150908134401.GA590@swordfish>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 08, 2015 at 10:44:01PM +0900, Sergey Senozhatsky wrote:
> dammit, not going to waste my time on this BS anymore.
> 
> 
> 
> > > --- a/drivers/block/zram/zram_drv.c
> > > +++ b/drivers/block/zram/zram_drv.c
> > > @@ -365,6 +365,9 @@ static ssize_t comp_algorithm_store(struct device *dev,
> > >  	struct zram *zram = dev_to_zram(dev);
> > >  	size_t sz;
> > >  
> > > +	if (!zcomp_available_algorithm(buf))
> > > +		return -EINVAL;
> > 
> > If you ignore tailling space, your change would make a bug.
> > If you fix it, it looks good to me.
> 
> that's why find_backend() calls sysfs_streq(), which takes care of
> a trailing new line. unless you're speaking about something else.

You're right. Your patch totally makes sense. Sorry for the niose.
Please resend it on another thread out of this BS thread with Ccing
Andrew.

> 
> 	-ss

-- 
Kind regards,
Minchan Kim