From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755260AbbIHPgU (ORCPT ); Tue, 8 Sep 2015 11:36:20 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:36247 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754618AbbIHPgR (ORCPT ); Tue, 8 Sep 2015 11:36:17 -0400 Date: Wed, 9 Sep 2015 00:35:11 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Sergey Senozhatsky , Luis Henriques , linux-kernel@vger.kernel.org Subject: Re: [PATCH] zram: don't copy invalid compression algorithms Message-ID: <20150908153511.GC590@swordfish> References: <20150908011443.GB19776@bbox> <20150908013338.GF6896@swordfish> <20150908015831.GG6896@swordfish> <20150908045017.GA30100@bbox> <20150908050442.GA609@swordfish> <20150908081610.GA8633@bbox> <20150908095428.GA14220@swordfish> <20150908133303.GA2174@bbox> <20150908134401.GA590@swordfish> <20150908142143.GA29714@blaptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150908142143.GA29714@blaptop> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (09/08/15 23:21), Minchan Kim wrote: [..] > > > If you ignore tailling space, your change would make a bug. > > > If you fix it, it looks good to me. > > > > that's why find_backend() calls sysfs_streq(), which takes care of > > a trailing new line. unless you're speaking about something else. > > You're right. Your patch totally makes sense. Sorry for the niose. > Please resend it on another thread out of this BS thread with Ccing > Andrew. patch resends better happen in separate threads. Luis, please Cc Andrew. I think the commit message also should document that this patch does change a user space visible behaviour in some cases (doesn't matter how seriously we take it, it better be 'documented'). -ss