Re: [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing

Jiri Olsa
2015-09-08T16:20:50Z

On Tue, Sep 08, 2015 at 09:03:17AM -0700, Andi Kleen wrote:
> > - introduce the print_metrics interface for perf_stat__print_shadow_stats
> > - introduce printout function
> > - introduce support for printing metrics in csv in interval mode
>
> That's already a separate patch.
>
> > - and enable i
> >
> >
> > or any other way you find feasible *easy to review*.. I cannot ack it at this state
>
> Well it's just printing out values. It's really not rocket science. Nobody
> is asking you to review a new VM subsystems or something like that.

right, it's easy.. and it should be done in 'easy to review' way

>
> I expect each more "refactoring" to add more problems. It's just really hard to to do,
> and usually adds more problems.

yep, that's why we test things

>
> I can try one more time, but if it doesn't work out we'll have to give up on this.

ok

jirka