Re: [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing

Jiri Olsa
2015-09-07T11:43:18Z

On Fri, Sep 04, 2015 at 03:45:13PM -0700, Andi Kleen wrote:

SNIP

> @@ -695,11 +743,7 @@ static void print_counter_aggr(struct perf_evsel *counter, char *prefix)
> }
>
> uval = avg * counter->scale;
> -
> - if (nsec_counter(counter))
> - nsec_printout(-1, 0, counter, uval);
> - else
> - abs_printout(-1, 0, counter, uval);
> + printout(-1, 0, counter, uval);
>
> print_noise(counter, avg);
>
> @@ -752,15 +796,9 @@ static void print_counter(struct perf_evsel *counter, char *prefix)
> }
>
> uval = val * counter->scale;
> -
> - if (nsec_counter(counter))
> - nsec_printout(cpu, 0, counter, uval);
> - else
> - abs_printout(cpu, 0, counter, uval);
> -
> + printout(cpu, 0, counter, uval);
> if (!csv_output)
> print_noise(counter, 1.0);
> - print_running(run, ena);

why is this one removed?

jirka