From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755166AbbIHQzb (ORCPT ); Tue, 8 Sep 2015 12:55:31 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:34387 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753379AbbIHQz2 (ORCPT ); Tue, 8 Sep 2015 12:55:28 -0400 Date: Tue, 8 Sep 2015 17:55:24 +0100 From: Leif Lindholm To: Mark Rutland Cc: "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-serial@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "al.stone@linaro.org" , "torez@redhat.com" , "jcm@redhat.com" , "graeme.gregory@linaro.org" , "linaro-acpi@lists.linaro.org" , "lv.zheng@intel.com" Subject: Re: [RFC 5/5] HACK: serial: move pl011 initcall to device_initcall Message-ID: <20150908165524.GO10728@bivouac.eciton.net> References: <1441716217-23786-1-git-send-email-leif.lindholm@linaro.org> <1441716217-23786-6-git-send-email-leif.lindholm@linaro.org> <20150908125608.GD20562@leverpostej> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150908125608.GD20562@leverpostej> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 08, 2015 at 01:56:08PM +0100, Mark Rutland wrote: > On Tue, Sep 08, 2015 at 01:43:37PM +0100, Leif Lindholm wrote: > > --- > > drivers/tty/serial/amba-pl011.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c > > index 452dbba..31cf985 100644 > > --- a/drivers/tty/serial/amba-pl011.c > > +++ b/drivers/tty/serial/amba-pl011.c > > @@ -2806,7 +2806,7 @@ static void __exit pl011_exit(void) > > * While this can be a module, if builtin it's most likely the console > > * So let's leave module_exit but move module_init to an earlier place > > */ > > -arch_initcall(pl011_init); > > +device_initcall(pl011_init); > > module_exit(pl011_exit); > > What's the ordering constraint that you're trying to solve with this? Basically that _CRS is not available until the ACPI subsystem is up - so when uart_add_one_port() calls acpi_console_check(), that function looks for a match against variables that have not been set yet. > The cover didn't mention anything, and there's no commit message. That's because I really don't want it committed :) > Mark. > > > > > MODULE_AUTHOR("ARM Ltd/Deep Blue Solutions Ltd"); > > -- > > 2.1.4 > >